From: Eduard Zingerman <eddyz87@gmail.com>
To: Emil Tsalapatis <emil@etsalapatis.com>, bpf@vger.kernel.org
Cc: andrii@kernel.org, ast@kernel.org, daniel@iogearbox.net,
john.fastabend@gmail.com, memxor@gmail.com,
yonghong.song@linux.dev
Subject: Re: [PATCH v3 3/5] libbpf: turn relo_core->sym_off unsigned
Date: Mon, 15 Dec 2025 12:05:52 -0800 [thread overview]
Message-ID: <048ca46153394d9ef555e7a5303d7ba74f237166.camel@gmail.com> (raw)
In-Reply-To: <20251215161313.10120-4-emil@etsalapatis.com>
On Mon, 2025-12-15 at 11:13 -0500, Emil Tsalapatis wrote:
> The symbols' relocation offsets in BPF are stored in an int field,
> but cannot actually be negative. When in the next patch libbpf relocates
> globals to the end of the arena, it is also possible to have valid
> offsets > 2GiB that are used to calculate the final relo offsets.
> Avoid accidentally interpreting large offsets as negative by turning
> the sym_off field unsigned.
>
> Signed-off-by: Emil Tsalapatis <emil@etsalapatis.com>
> ---
(But agree with the nit from LLM, create_jt_map() should be updated
for consistency).
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2025-12-15 20:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-15 16:13 [PATCH v3 0/5] libbpf: move arena variables out of the zero page Emil Tsalapatis
2025-12-15 16:13 ` [PATCH v3 1/5] selftests/bpf: explicitly account for globals in verifier_arena_large Emil Tsalapatis
2025-12-15 16:13 ` [PATCH v3 2/5] bpf/verifier: do not limit maximum direct offset into arena map Emil Tsalapatis
2025-12-15 20:19 ` Eduard Zingerman
2025-12-16 17:25 ` Emil Tsalapatis
2025-12-16 20:13 ` Eduard Zingerman
2025-12-16 21:48 ` Emil Tsalapatis
2025-12-15 16:13 ` [PATCH v3 3/5] libbpf: turn relo_core->sym_off unsigned Emil Tsalapatis
2025-12-15 16:37 ` bot+bpf-ci
2025-12-15 17:08 ` Emil Tsalapatis
2025-12-15 20:05 ` Eduard Zingerman [this message]
2025-12-15 16:13 ` [PATCH v3 4/5] libbpf: move arena globals to the end of the arena Emil Tsalapatis
2025-12-15 21:12 ` Eduard Zingerman
2025-12-15 16:13 ` [PATCH v3 5/5] selftests/bpf: add tests for the arena offset of globals Emil Tsalapatis
2025-12-15 21:26 ` Eduard Zingerman
2025-12-16 2:28 ` Emil Tsalapatis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=048ca46153394d9ef555e7a5303d7ba74f237166.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=emil@etsalapatis.com \
--cc=john.fastabend@gmail.com \
--cc=memxor@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox