From: Jacob Keller <jacob.e.keller@intel.com>
To: Larysa Zaremba <larysa.zaremba@intel.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<bpf@vger.kernel.org>, <magnus.karlsson@intel.com>,
Michal Kubiak <michal.kubiak@intel.com>,
Wojciech Drewek <wojciech.drewek@intel.com>,
Amritha Nambiar <amritha.nambiar@intel.com>
Subject: Re: [PATCH iwl-net v2 3/6] ice: check for XDP rings instead of bpf program when unconfiguring
Date: Wed, 24 Jul 2024 11:25:16 -0700 [thread overview]
Message-ID: <04b468d6-713c-4a87-9fd3-4821626c4244@intel.com> (raw)
In-Reply-To: <20240724164840.2536605-4-larysa.zaremba@intel.com>
On 7/24/2024 9:48 AM, Larysa Zaremba wrote:
> If VSI rebuild is pending, .ndo_bpf() can attach/detach the XDP program on
> VSI without applying new ring configuration. When unconfiguring the VSI, we
> can encounter the state in which there is an XDP program but no XDP rings
> to destroy or there will be XDP rings that need to be destroyed, but no XDP
> program to indicate their presence.
>
> When unconfiguring, rely on the presence of XDP rings rather then XDP
> program, as they better represent the current state that has to be
> destroyed.
>
> Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>
> Signed-off-by: Larysa Zaremba <larysa.zaremba@intel.com>
> ---
Right. When operating on the rings, we should be checking xdp_rings. Ok.
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
next prev parent reply other threads:[~2024-07-24 18:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 16:48 [PATCH iwl-net v2 0/6] ice: fix synchronization between .ndo_bpf() and reset Larysa Zaremba
2024-07-24 16:48 ` [PATCH iwl-net v2 1/6] ice: move netif_queue_set_napi to rtnl-protected sections Larysa Zaremba
2024-07-24 18:21 ` Jacob Keller
2024-07-24 20:40 ` Nambiar, Amritha
2024-08-08 2:19 ` [Intel-wired-lan] " Rout, ChandanX
2024-07-24 16:48 ` [PATCH iwl-net v2 2/6] ice: protect XDP configuration with a mutex Larysa Zaremba
2024-07-24 18:24 ` Jacob Keller
2024-08-08 2:16 ` [Intel-wired-lan] " Rout, ChandanX
2024-08-13 11:31 ` Maciej Fijalkowski
2024-08-13 13:36 ` Larysa Zaremba
2024-07-24 16:48 ` [PATCH iwl-net v2 3/6] ice: check for XDP rings instead of bpf program when unconfiguring Larysa Zaremba
2024-07-24 18:25 ` Jacob Keller [this message]
2024-08-08 2:18 ` [Intel-wired-lan] " Rout, ChandanX
2024-08-12 12:58 ` Maciej Fijalkowski
2024-08-12 15:13 ` Larysa Zaremba
2024-07-24 16:48 ` [PATCH iwl-net v2 4/6] ice: check ICE_VSI_DOWN under rtnl_lock when preparing for reset Larysa Zaremba
2024-07-24 18:27 ` Jacob Keller
2024-08-08 2:15 ` [Intel-wired-lan] " Rout, ChandanX
2024-07-24 16:48 ` [PATCH iwl-net v2 5/6] ice: remove ICE_CFG_BUSY locking from AF_XDP code Larysa Zaremba
2024-07-24 18:37 ` Jacob Keller
2024-08-08 2:17 ` [Intel-wired-lan] " Rout, ChandanX
2024-08-12 13:03 ` Maciej Fijalkowski
2024-08-12 15:59 ` Larysa Zaremba
2024-08-13 10:28 ` Maciej Fijalkowski
2024-07-24 16:48 ` [PATCH iwl-net v2 6/6] ice: do not bring the VSI up, if it was down before the XDP setup Larysa Zaremba
2024-07-24 18:40 ` Jacob Keller
2024-08-08 2:14 ` [Intel-wired-lan] " Rout, ChandanX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04b468d6-713c-4a87-9fd3-4821626c4244@intel.com \
--to=jacob.e.keller@intel.com \
--cc=amritha.nambiar@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=larysa.zaremba@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=michal.kubiak@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox