From: "Björn Töpel" <bjorn.topel@intel.com>
To: "Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Björn Töpel" <bjorn.topel@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org,
bpf@vger.kernel.org, andrii@kernel.org,
magnus.karlsson@intel.com, maximmi@nvidia.com,
ciara.loftus@intel.com
Subject: Re: [PATCH bpf-next 2/2] libbpf: xsk: move barriers from libbpf_util.h to xsk.h
Date: Thu, 11 Mar 2021 07:59:46 +0100 [thread overview]
Message-ID: <0535ce9f-0db6-40f7-e512-e327f6f54c35@intel.com> (raw)
In-Reply-To: <20210311000605.tuo7rg4b7keo76iy@bsd-mbp.dhcp.thefacebook.com>
On 2021-03-11 01:06, Jonathan Lemon wrote:
> On Wed, Mar 10, 2021 at 09:09:29AM +0100, Björn Töpel wrote:
>> From: Björn Töpel <bjorn.topel@intel.com>
>>
>> The only user of libbpf_util.h is xsk.h. Move the barriers to xsk.h,
>> and remove libbpf_util.h. The barriers are used as an implementation
>> detail, and should not be considered part of the stable API.
>
> Does that mean that anything else which uses the same type of
> shared rings (bpf ringbuffer, io_uring, zctap) have to implement
> the same primitives that xsk.h has?
>
Jonathan, there's a longer explanation on back-/forward-compatibility in
the commit message [1]. Again, this is for the XDP socket rings, so I
wont comment on the other rings. I would not assume compatibility
between different rings (e.g. the bpf ringbuffer and XDP sockets rings),
not even prior the barrier change.
Björn
[1]
https://lore.kernel.org/bpf/20210305094113.413544-2-bjorn.topel@gmail.com/
next prev parent reply other threads:[~2021-03-11 7:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 8:09 [PATCH bpf-next 0/2] libbpf/xsk cleanups Björn Töpel
2021-03-10 8:09 ` [PATCH bpf-next 1/2] libbpf: xsk: remove linux/compiler.h header Björn Töpel
2021-03-10 8:09 ` [PATCH bpf-next 2/2] libbpf: xsk: move barriers from libbpf_util.h to xsk.h Björn Töpel
2021-03-10 22:00 ` Andrii Nakryiko
2021-03-11 0:06 ` Jonathan Lemon
2021-03-11 6:59 ` Björn Töpel [this message]
2021-03-11 18:56 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0535ce9f-0db6-40f7-e512-e327f6f54c35@intel.com \
--to=bjorn.topel@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=ciara.loftus@intel.com \
--cc=daniel@iogearbox.net \
--cc=jonathan.lemon@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox