BPF List
 help / color / mirror / Atom feed
From: Quentin Monnet <quentin@isovalent.com>
To: "Daniel Müller" <deso@posteo.net>,
	bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
	daniel@iogearbox.net, kernel-team@fb.com
Subject: Re: [PATCH bpf-next 0/2] Add KIND_RESTRICT support to bpftool
Date: Thu, 7 Jul 2022 10:14:32 +0100	[thread overview]
Message-ID: <05a05458-9673-8556-443c-a80902aedba2@isovalent.com> (raw)
In-Reply-To: <20220706212855.1700615-1-deso@posteo.net>

On 06/07/2022 22:28, Daniel Müller wrote:
> As pointed out in an earlier discussion [0] not all paths in bpftool's
> minimization logic handle the restrict type qualifier properly. Specifically,
> the gen min_core_btf command fails when encountering the corresponding BTF kind
> for a TYPE_EXISTS relocation (TYPE_MATCHES support was added earlier):
>   > Error: unsupported kind: restrict (26)
> 
> This patch set fixes this short coming.
> 
> [0]: https://lore.kernel.org/bpf/20220623212205.2805002-1-deso@posteo.net/T/#m4c75205145701762a4b398e0cdb911d5b5305ffc
> 
> Daniel Müller (2):
>   bpftool: Add support for KIND_RESTRICT to gen min_core_btf command
>   selftests/bpf: Add test involving restrict type qualifier
> 
>  tools/bpf/bpftool/gen.c                                   | 1 +
>  tools/testing/selftests/bpf/prog_tests/core_reloc.c       | 2 ++
>  tools/testing/selftests/bpf/progs/core_reloc_types.h      | 8 ++++++--
>  .../selftests/bpf/progs/test_core_reloc_type_based.c      | 5 +++++
>  4 files changed, 14 insertions(+), 2 deletions(-)
> 

Acked-by: Quentin Monnet <quentin@isovalent.com>
Thanks!

  parent reply	other threads:[~2022-07-07  9:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-06 21:28 [PATCH bpf-next 0/2] Add KIND_RESTRICT support to bpftool Daniel Müller
2022-07-06 21:28 ` [PATCH bpf-next 1/2] bpftool: Add support for KIND_RESTRICT to gen min_core_btf command Daniel Müller
2022-07-06 21:28 ` [PATCH bpf-next 2/2] selftests/bpf: Add test involving restrict type qualifier Daniel Müller
2022-07-07  9:14 ` Quentin Monnet [this message]
2022-07-08 12:30 ` [PATCH bpf-next 0/2] Add KIND_RESTRICT support to bpftool patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05a05458-9673-8556-443c-a80902aedba2@isovalent.com \
    --to=quentin@isovalent.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=deso@posteo.net \
    --cc=kernel-team@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox