* [PATCH bpf-next 2/2] libbpf: fix signedness determination in CO-RE relo handling logic
2023-08-24 0:00 [PATCH bpf-next 1/2] selftests/bpf: add uprobe_multi test binary to .gitignore Andrii Nakryiko
@ 2023-08-24 0:00 ` Andrii Nakryiko
2023-08-24 0:43 ` Yonghong Song
2023-08-24 0:42 ` [PATCH bpf-next 1/2] selftests/bpf: add uprobe_multi test binary to .gitignore Yonghong Song
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Andrii Nakryiko @ 2023-08-24 0:00 UTC (permalink / raw)
To: bpf, ast, daniel, martin.lau; +Cc: andrii, kernel-team, Lorenz Bauer
Extracting btf_int_encoding() is only meaningful for BTF_KIND_INT, so we
need to check that first before inferring signedness.
Closes: https://github.com/libbpf/libbpf/issues/704
Reported-by: Lorenz Bauer <lmb@isovalent.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
---
tools/lib/bpf/relo_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/lib/bpf/relo_core.c b/tools/lib/bpf/relo_core.c
index a26b2f5fa0fc..63a4d5ad12d1 100644
--- a/tools/lib/bpf/relo_core.c
+++ b/tools/lib/bpf/relo_core.c
@@ -776,7 +776,7 @@ static int bpf_core_calc_field_relo(const char *prog_name,
break;
case BPF_CORE_FIELD_SIGNED:
*val = (btf_is_any_enum(mt) && BTF_INFO_KFLAG(mt->info)) ||
- (btf_int_encoding(mt) & BTF_INT_SIGNED);
+ (btf_is_int(mt) && (btf_int_encoding(mt) & BTF_INT_SIGNED));
if (validate)
*validate = true; /* signedness is never ambiguous */
break;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH bpf-next 1/2] selftests/bpf: add uprobe_multi test binary to .gitignore
2023-08-24 0:00 [PATCH bpf-next 1/2] selftests/bpf: add uprobe_multi test binary to .gitignore Andrii Nakryiko
2023-08-24 0:00 ` [PATCH bpf-next 2/2] libbpf: fix signedness determination in CO-RE relo handling logic Andrii Nakryiko
@ 2023-08-24 0:42 ` Yonghong Song
2023-08-24 4:50 ` patchwork-bot+netdevbpf
2023-08-24 13:07 ` Jiri Olsa
3 siblings, 0 replies; 6+ messages in thread
From: Yonghong Song @ 2023-08-24 0:42 UTC (permalink / raw)
To: Andrii Nakryiko, bpf, ast, daniel, martin.lau; +Cc: kernel-team
On 8/23/23 5:00 PM, Andrii Nakryiko wrote:
> It seems like it was forgotten to add uprobe_multi binary to .gitignore.
> Fix this trivial omission.
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
I actually noticed this problem as well. Thanks for the fix!
Acked-by: Yonghong Song <yonghong.song@linux.dev>
> ---
> tools/testing/selftests/bpf/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
> index 110518ba4804..f1aebabfb017 100644
> --- a/tools/testing/selftests/bpf/.gitignore
> +++ b/tools/testing/selftests/bpf/.gitignore
> @@ -44,6 +44,7 @@ test_cpp
> /bench
> /veristat
> /sign-file
> +/uprobe_multi
> *.ko
> *.tmp
> xskxceiver
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH bpf-next 1/2] selftests/bpf: add uprobe_multi test binary to .gitignore
2023-08-24 0:00 [PATCH bpf-next 1/2] selftests/bpf: add uprobe_multi test binary to .gitignore Andrii Nakryiko
2023-08-24 0:00 ` [PATCH bpf-next 2/2] libbpf: fix signedness determination in CO-RE relo handling logic Andrii Nakryiko
2023-08-24 0:42 ` [PATCH bpf-next 1/2] selftests/bpf: add uprobe_multi test binary to .gitignore Yonghong Song
@ 2023-08-24 4:50 ` patchwork-bot+netdevbpf
2023-08-24 13:07 ` Jiri Olsa
3 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-24 4:50 UTC (permalink / raw)
To: Andrii Nakryiko; +Cc: bpf, ast, daniel, martin.lau, kernel-team
Hello:
This series was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Wed, 23 Aug 2023 17:00:15 -0700 you wrote:
> It seems like it was forgotten to add uprobe_multi binary to .gitignore.
> Fix this trivial omission.
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> ---
> tools/testing/selftests/bpf/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- [bpf-next,1/2] selftests/bpf: add uprobe_multi test binary to .gitignore
https://git.kernel.org/bpf/bpf-next/c/a182e64147f7
- [bpf-next,2/2] libbpf: fix signedness determination in CO-RE relo handling logic
https://git.kernel.org/bpf/bpf-next/c/f3bdb54f09ab
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH bpf-next 1/2] selftests/bpf: add uprobe_multi test binary to .gitignore
2023-08-24 0:00 [PATCH bpf-next 1/2] selftests/bpf: add uprobe_multi test binary to .gitignore Andrii Nakryiko
` (2 preceding siblings ...)
2023-08-24 4:50 ` patchwork-bot+netdevbpf
@ 2023-08-24 13:07 ` Jiri Olsa
3 siblings, 0 replies; 6+ messages in thread
From: Jiri Olsa @ 2023-08-24 13:07 UTC (permalink / raw)
To: Andrii Nakryiko; +Cc: bpf, ast, daniel, martin.lau, kernel-team
On Wed, Aug 23, 2023 at 05:00:15PM -0700, Andrii Nakryiko wrote:
> It seems like it was forgotten to add uprobe_multi binary to .gitignore.
> Fix this trivial omission.
>
> Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
> ---
> tools/testing/selftests/bpf/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
> index 110518ba4804..f1aebabfb017 100644
> --- a/tools/testing/selftests/bpf/.gitignore
> +++ b/tools/testing/selftests/bpf/.gitignore
> @@ -44,6 +44,7 @@ test_cpp
> /bench
> /veristat
> /sign-file
> +/uprobe_multi
> *.ko
> *.tmp
> xskxceiver
> --
> 2.34.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread