From: Yonghong Song <yonghong.song@linux.dev>
To: Manu Bretelle <chantr4@gmail.com>,
bpf@vger.kernel.org, andrii@kernel.org, daniel@iogearbox.net,
ast@kernel.org, martin.lau@linux.dev, song@kernel.org,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, mykolal@fb.com,
shuah@kernel.org
Subject: Re: [PATCH bpf-next] selftests/bpf: fix test_bpffs
Date: Fri, 27 Oct 2023 19:06:01 -0700 [thread overview]
Message-ID: <06ff963d-6d75-43dc-bb95-b1a5e977c6e6@linux.dev> (raw)
In-Reply-To: <20231027223006.2062967-1-chantr4@gmail.com>
On 10/27/23 3:30 PM, Manu Bretelle wrote:
> Currently this tests tries to umount /sys/kernel/debug (TDIR) but the
> system it is running on may have mounts below.
>
> For example, danobi/vmtest [0] VMs have
> mount -t tracefs tracefs /sys/kernel/debug/tracing
> as part of their init.
>
> This change instead creates a "random" directory under /tmp and uses this
> as TDIR.
> If the directory already exists, ignore the error and keep moving on.
>
> Test:
>
> Originally:
>
> $ vmtest -k $KERNEL_REPO/arch/x86_64/boot/bzImage "./test_progs -vv -a test_bpffs"
> => bzImage
> ===> Booting
> ===> Setting up VM
> ===> Running command
> [ 2.138818] bpf_testmod: loading out-of-tree module taints kernel.
> [ 2.140913] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel
> bpf_testmod.ko is already unloaded.
> Loading bpf_testmod.ko...
> Successfully loaded bpf_testmod.ko.
> test_test_bpffs:PASS:clone 0 nsec
> fn:PASS:unshare 0 nsec
> fn:PASS:mount / 0 nsec
> fn:FAIL:umount /sys/kernel/debug unexpected error: -1 (errno 16)
> bpf_testmod.ko is already unloaded.
> Loading bpf_testmod.ko...
> Successfully loaded bpf_testmod.ko.
> test_test_bpffs:PASS:clone 0 nsec
> test_test_bpffs:PASS:waitpid 0 nsec
> test_test_bpffs:FAIL:bpffs test failed 255#282 test_bpffs:FAIL
> Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED
> Successfully unloaded bpf_testmod.ko.
> Command failed with exit code: 1
>
> After this change:
>
> $ vmtest -k $KERNEL_REPO/arch/x86_64/boot/bzImage "./test_progs -vv -a test_bpffs"
> => bzImage
> ===> Booting
> ===> Setting up VM
> ===> Running command
> [ 2.119236] bpf_testmod: loading out-of-tree module taints kernel.
> [ 2.121768] bpf_testmod: module verification failed: signature and/or required key missing - tainting kernel
> bpf_testmod.ko is already unloaded.
> Loading bpf_testmod.ko...
> Successfully loaded bpf_testmod.ko.
> test_test_bpffs:PASS:clone 0 nsec
> fn:PASS:unshare 0 nsec
> fn:PASS:mount / 0 nsec
> fn:PASS:mount tmpfs 0 nsec
> fn:PASS:mkdir /tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1 0 nsec
> fn:PASS:mkdir /tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs2 0 nsec
> fn:PASS:mount bpffs /tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1 0 nsec
> fn:PASS:mount bpffs /tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs2 0 nsec
> fn:PASS:reading /tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/maps.debug 0 nsec
> fn:PASS:reading /tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs2/progs.debug 0 nsec
> fn:PASS:creating /tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/a 0 nsec
> fn:PASS:creating /tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/a/1 0 nsec
> fn:PASS:creating /tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/b 0 nsec
> fn:PASS:create_map(ARRAY) 0 nsec
> fn:PASS:pin map 0 nsec
> fn:PASS:stat(/tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/a) 0 nsec
> fn:PASS:renameat2(/fs1/a, /fs1/b, RENAME_EXCHANGE) 0 nsec
> fn:PASS:stat(/tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/b) 0 nsec
> fn:PASS:b should have a's inode 0 nsec
> fn:PASS:access(/tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/b/1) 0 nsec
> fn:PASS:stat(/tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/map) 0 nsec
> fn:PASS:renameat2(/fs1/c, /fs1/b, RENAME_EXCHANGE) 0 nsec
> fn:PASS:stat(/tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/b) 0 nsec
> fn:PASS:b should have c's inode 0 nsec
> fn:PASS:access(/tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/c/1) 0 nsec
> fn:PASS:renameat2(RENAME_NOREPLACE) 0 nsec
> fn:PASS:access(/tmp/vvnlhrgunvkrfegnlrvnggcudfgdtrhbfelkebeurfed/fs1/b) 0 nsec
> bpf_testmod.ko is already unloaded.
> Loading bpf_testmod.ko...
> Successfully loaded bpf_testmod.ko.
> test_test_bpffs:PASS:clone 0 nsec
> test_test_bpffs:PASS:waitpid 0 nsec
> test_test_bpffs:PASS:bpffs test 0 nsec
> #282 test_bpffs:OK
> Summary: 1/0 PASSED, 0 SKIPPED, 0 FAILED
> Successfully unloaded bpf_testmod.ko.
>
> [0] https://github.com/danobi/vmtest
>
> This is a follow-up of https://lore.kernel.org/bpf/20231024201852.1512720-1-chantr4@gmail.com/T/
>
> Signed-off-by: Manu Bretelle <chantr4@gmail.com>
Acked-by: Yonghong Song <yonghong.song@linux.dev>
next prev parent reply other threads:[~2023-10-28 2:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 22:30 [PATCH bpf-next] selftests/bpf: fix test_bpffs Manu Bretelle
2023-10-28 2:06 ` Yonghong Song [this message]
2023-10-31 6:29 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06ff963d-6d75-43dc-bb95-b1a5e977c6e6@linux.dev \
--to=yonghong.song@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=chantr4@gmail.com \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox