From: David Marchevsky <david.marchevsky@linux.dev>
To: Dave Marchevsky <davemarchevsky@fb.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@kernel.org>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v5 bpf-next 4/4] selftests/bpf: Add tests for open-coded task_vma iter
Date: Tue, 10 Oct 2023 14:38:51 -0400 [thread overview]
Message-ID: <0722d3e1-7f89-439a-ac31-d310fd25e30b@linux.dev> (raw)
In-Reply-To: <20231010175637.3405682-5-davemarchevsky@fb.com>
On 10/10/23 1:56 PM, Dave Marchevsky wrote:
> The open-coded task_vma iter added earlier in this series allows for
> natural iteration over a task's vmas using existing open-coded iter
> infrastructure, specifically bpf_for_each.
>
> This patch adds a test demonstrating this pattern and validating
> correctness. The vma->vm_start and vma->vm_end addresses of the first
> 1000 vmas are recorded and compared to /proc/PID/maps output. As
> expected, both see the same vmas and addresses - with the exception of
> the [vsyscall] vma - which is explained in a comment in the prog_tests
> program.
>
> Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com>
> ---
BPF CI is unhappy as it's unable to apply this patch.
Likely because I manually deleted an extraneous empty line
in the .patch file.
Will respin as v6 shortly.
prev parent reply other threads:[~2023-10-10 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 17:56 [PATCH v5 bpf-next 0/4] Open-coded task_vma iter Dave Marchevsky
2023-10-10 17:56 ` [PATCH v5 bpf-next 1/4] bpf: Don't explicitly emit BTF for struct btf_iter_num Dave Marchevsky
2023-10-10 17:56 ` [PATCH v5 bpf-next 2/4] selftests/bpf: Rename bpf_iter_task_vma.c to bpf_iter_task_vmas.c Dave Marchevsky
2023-10-10 17:56 ` [PATCH v5 bpf-next 3/4] bpf: Introduce task_vma open-coded iterator kfuncs Dave Marchevsky
2023-10-10 17:56 ` [PATCH v5 bpf-next 4/4] selftests/bpf: Add tests for open-coded task_vma iter Dave Marchevsky
2023-10-10 18:38 ` David Marchevsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0722d3e1-7f89-439a-ac31-d310fd25e30b@linux.dev \
--to=david.marchevsky@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox