From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A487E3A0B3F for ; Tue, 26 May 2026 10:53:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779792808; cv=none; b=jKUK9CeoQyzhIUGXjxRpd8gP8clPFtxgcZiPa86lQyxVZ0FGzNqRz2NeHq5vSGWk9/PqPVMS7+FJrR3e5kAysSQZWqepB4f/1MU76YOTvzEHjL7XDM4ugdwB2UGNkC/4qaKoP76/wgEb8Y9/AAWZeY0OE+9ZpR2GnBkm1CF0RvY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779792808; c=relaxed/simple; bh=2IkIxZNvBAu13Ws4fKNVPeBXSlEtFgUgVx7YLgf7FqE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=efeQWMMjMRMfb5AFMelVrm3WIOOAnuvaviN+bDflJTkU1vnrikwUMzexegUxcqPe7oVQSf5ptUtb7qUpiImx30esXv8x/7kvPfdVo5l82jr8HoQHIcNAxQjjIclAOlBMNf2Db5RqhnAJo4DURyy6+VhnVt84pa99Eow15aC48Yc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=P9vj4BDJ; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="P9vj4BDJ" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-44e1860558fso6663431f8f.0 for ; Tue, 26 May 2026 03:53:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1779792804; x=1780397604; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ankQ6/0PQUNDJRsfxZkkDwmN1Szk45mZhdmBSOH36Gk=; b=P9vj4BDJ738bEySM3lt0h10n0hFn2Ykf0bT4a2Ll2krlRcxNrmJeB0syyRYI6qsWiL KcemkmekriERSdv9CZwdKcd8B4MLcfYU20brkmsELktEXxiUuOhni82tA4J9/a3JhPyX FYbvNfo52NRmuEbOOlML/hghFkxL9ghyvu/UG2Xe9wkOpuHhZkDThcZdSacQlbHMohwl VClNx+443LrxM+VJrbHTQ2vd8eKuItYd12wD9sQBySuyelP0e5ZeJVW5RIpSqQZo1hQF Hp82oIo3QlZwwIKSWGmjzXT52yIKF+m9a9s34CXrRp1Fneg5HFHq/gtmu41dpQl54wUR WSFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779792804; x=1780397604; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ankQ6/0PQUNDJRsfxZkkDwmN1Szk45mZhdmBSOH36Gk=; b=lGtlUnkwGYe4yQTFvBOoHWqttDg4GGjaEt4W2eIMkRxxMnfEPsiA/BHdBQCurPcvWP kT1uxTUWXFjBe7oQSfbK9LxbjiTAv3H26xlYKbd3/cSWdqpnoQEF9F5rLtALERX7tkYy CdQHFOtmrc+kwWPBYxQRnZcbJ+xqFnvrZPwcNph17ig/Ic1rncQirseeEZFUHQOUM4gH gNlIkSMN9DL0e/glcO0+UyrPJsMFc4BoJPlpRtEddX+mNliX0YpiG+auo3yOVpvZaFKX lj+iCKaG9lpXssyCKpEakxj4RUNn1K5XkvCnSHptaF9qHSp3PpgzD3CQAJQInbn/nSPm I2rw== X-Forwarded-Encrypted: i=1; AFNElJ8G4uFRuVUDzLE1b+rW65g821iimMXC+LYWgNuyQX/+ylOCJHGimo2XLhuqaDhRP6tI8SA=@vger.kernel.org X-Gm-Message-State: AOJu0YysY2oxG7DB6xmupSQ90vi8KAeYn5cUxGEEy3bmkeSSoH8qjJAl OMs1NBfjWISJKohrP6A/9ZooGAkPAa/m7NZt07SGZHByRj2uOU1Iv8wXrBLxVeR8/eg= X-Gm-Gg: Acq92OFTe5rp+9vTuwewUIpC0e/thgaTNnbdJb+o6/Mji5NZsxV9UibsVrkLCO8oIRM x1YYPXNBEOLU+jl4tPB+ks9BxwNu7lClRgOJV6tLNViRcbxShVh1AjDSUiaCzMSMvlEFU9pKzG7 RCYNDV8avUMCbOXFpAqMeSUaSLo6slMVzGBTYCz+W7KyecH+TYowz/TLw+mQLqiKrDAESxsN1mW jgmyv/qOwh8n2Gt3iP7oXGTtl4rBQHAKB1k9dnPS4rYPXB0GCV+YhFdIb7DnD8uyiLT6RDurzr0 mUxhY2HnFUhheaVFJfIOqDVIjKKp7UhVnWzgTaff3vvKCiFwbdUle7r4hl5vXKzoAvGtrwmvizE ZwKihGOd58kw12RQei80uVPZt/a8gRF/vWnAjcHqzdNQRqAgd8LKaZpUlGLVuPH4ZwdfsFCoaU3 urCCQrfYmPstMqiD9ZQmOnVVX895p356UkypwGlp1/jnxqiGIDEAMD0qlhjBmhK2Zov4rnPWQ72 m7Bb6NYCf8oovdC/i7fLBJmGIfpq3xdEIMS6/dRw1O1pEzxQGBx9NBrbXVmLW/hibUpow== X-Received: by 2002:a05:6000:2889:b0:43c:fdd:ea96 with SMTP id ffacd0b85a97d-45eb38c5259mr30630897f8f.26.1779792804025; Tue, 26 May 2026 03:53:24 -0700 (PDT) Received: from ?IPV6:2a00:1028:838d:271e:8e3b:4aff:fe4c:a100? (dynamic-2a00-1028-838d-271e-8e3b-4aff-fe4c-a100.ipv6.o2.cz. [2a00:1028:838d:271e:8e3b:4aff:fe4c:a100]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6bc5479sm36850849f8f.0.2026.05.26.03.53.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 May 2026 03:53:23 -0700 (PDT) Message-ID: <0a0736a4-2cdd-49f2-9062-e2f18d769fc0@suse.com> Date: Tue, 26 May 2026 12:53:22 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 07/14] module: Make module authentication usable without MODULE_SIG To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Eduard Zingerman , Kumar Kartikeya Dwivedi , Nathan Chancellor , Nicolas Schier , Arnd Bergmann , Luis Chamberlain , Sami Tolvanen , Daniel Gomez , Paul Moore , James Morris , "Serge E. Hallyn" , Jonathan Corbet , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Mimi Zohar , Roberto Sassu , Dmitry Kasatkin , Eric Snowberg , Nicolas Schier , Daniel Gomez , Aaron Tomlin , "Christophe Leroy (CS GROUP)" , Nicolas Bouchinet , Xiu Jianfeng , Martin KaFai Lau , Song Liu , Yonghong Song , Jiri Olsa , bpf@vger.kernel.org, =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= , Arnout Engelen , Mattia Rizzolo , kpcyrd , Christian Heusel , =?UTF-8?Q?C=C3=A2ju_Mihai-Drosi?= , Eric Biggers , Sebastian Andrzej Siewior , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-modules@vger.kernel.org, linux-security-module@vger.kernel.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-integrity@vger.kernel.org, debian-kernel@lists.debian.org References: <20260505-module-hashes-v5-0-e174a5a49fce@weissschuh.net> <20260505-module-hashes-v5-7-e174a5a49fce@weissschuh.net> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260505-module-hashes-v5-7-e174a5a49fce@weissschuh.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/5/26 11:05 AM, Thomas Weißschuh wrote: > The module authentication functionality will also be used by the > hash-based module authentication. Split it out from CONFIG_MODULE_SIG > so it is usable by both. > > Signed-off-by: Thomas Weißschuh > [...] > diff --git a/kernel/module/Kconfig b/kernel/module/Kconfig > index f535181e0d98..84297da666ff 100644 > --- a/kernel/module/Kconfig > +++ b/kernel/module/Kconfig > @@ -271,9 +271,12 @@ config MODULE_SIG > debuginfo strip done by some packagers (such as rpmbuild) and > inclusion into an initramfs that wants the module size reduced. > > +config MODULE_AUTH > + def_bool MODULE_SIG > + > config MODULE_SIG_FORCE > bool "Require modules to be validly signed" > - depends on MODULE_SIG > + depends on MODULE_AUTH > help > Reject unsigned modules or signed modules for which we don't have a > key. Without this, such modules will simply taint the kernel. Should MODULE_SIG_FORCE be renamed to MODULE_AUTH_FORCE, along with renaming the sig_enforce functionality in kernel/module/auth.c to auth_enforce? -- Thanks, Petr