From: Daniel Borkmann <daniel@iogearbox.net>
To: Stanislav Fomichev <sdf@google.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: davem@davemloft.net, ast@kernel.org, kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH bpf-next] bpf: fix missing bpf_check_uarg_tail_zero in BPF_PROG_TEST_RUN
Date: Thu, 11 Apr 2019 21:52:55 +0200 [thread overview]
Message-ID: <0ae7a9ae-1d07-afaf-c31f-1c46f48df9f2@iogearbox.net> (raw)
In-Reply-To: <20190411161202.167610-1-sdf@google.com>
On 04/11/2019 06:12 PM, Stanislav Fomichev wrote:
> Commit b0b9395d865e ("bpf: support input __sk_buff context in
> BPF_PROG_TEST_RUN") started using bpf_check_uarg_tail_zero in
> BPF_PROG_TEST_RUN. However, bpf_check_uarg_tail_zero is not defined
> for !CONFIG_BPF_SYSCALL:
>
> net/bpf/test_run.c: In function ‘bpf_ctx_init’:
> net/bpf/test_run.c:142:9: error: implicit declaration of function ‘bpf_check_uarg_tail_zero’ [-Werror=implicit-function-declaration]
> err = bpf_check_uarg_tail_zero(data_in, max_size, size);
> ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Let's not build net/bpf/test_run.c when CONFIG_BPF_SYSCALL is not set.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Fixes: b0b9395d865e ("bpf: support input __sk_buff context in BPF_PROG_TEST_RUN")
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
Makes sense, applied, thanks!
prev parent reply other threads:[~2019-04-11 19:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 16:12 [PATCH bpf-next] bpf: fix missing bpf_check_uarg_tail_zero in BPF_PROG_TEST_RUN Stanislav Fomichev
2019-04-11 19:52 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ae7a9ae-1d07-afaf-c31f-1c46f48df9f2@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).