From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 175112E406 for ; Tue, 22 Oct 2024 15:30:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729611039; cv=none; b=Zro1w2vgXvcY8pVQFvZjBPTQVZ4vYOrZ7yBfCW8TMeIASjRdfgbk2Sm4kjZk2HKqy1cRgT1WAZ83N4zbv3DDddMwmPoTtGrdqEHIWeB2/OcS5qmBcYKC7pSx0w1ZdymIzM6FuO/lYHCA3EpVs1b+Xhvs8N8qCY25yfxA0qLkiVw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729611039; c=relaxed/simple; bh=aeNB2y0zQoaicGC/OFWTx8R6AjoXO4apTD26syH9b1c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=F7TZZhbBS3OwK7J+EC8WZScFEZqaezhPiC4JQbAWOw6yEE8w40IqttAIV+/6e7i0EJ5/ecsl26ZshqISyHUqKCx9pncc/i7GuXxJngBXiXdoWGMrAKgIATgqG15ejbUkzuEP2RhHypQdNHmJ/ggdmnfB7D+ZkgyJeP5cFj2CRRQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=VsaYfPUm; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="VsaYfPUm" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729611037; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aeNB2y0zQoaicGC/OFWTx8R6AjoXO4apTD26syH9b1c=; b=VsaYfPUmHV+kUK/5TNgha1YXjtBbmg7467SOY6ryRovBr8Ug/dFE8QSc8htusmdw/PgBw8 Y0Gvs3GbyP+UYvGCcIO8ZCUmveNP87ruotGIbnl+8f/meBJgyQf8nYM+xUtnw8lEhF8l5E 8UgYbr4FreqMBmPdnB5sUyEBB/X51Kg= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-252-tgQr9zbpN4aj7UFUaCj2mA-1; Tue, 22 Oct 2024 11:30:35 -0400 X-MC-Unique: tgQr9zbpN4aj7UFUaCj2mA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-37d5a3afa84so3052099f8f.3 for ; Tue, 22 Oct 2024 08:30:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729611034; x=1730215834; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aeNB2y0zQoaicGC/OFWTx8R6AjoXO4apTD26syH9b1c=; b=r8x10izJvoR+A2KWg+weJzMG/qJ6Tu35fkyRcGhLts58qX+qJ79pYRGsPXmXMj6b/f bG9WGWgMaehvhUMXjHb53axsGN2f9Tv7Spg+pGAWPKXu2yFJlh0MRKkORDABe0K6q/jW qDzQPk3SE2NOthGcgnl+5ePRt+fMWi5AL0kbgsunTLKWXxvs1wRgiEZJrwsFIUD4euAt 0blvi4qHZpgro0ayECkVgm3Qg86ZyCwWaDU2QcSDXnqDUbast7ErAqrqP2b8OeX9iFtE iqJ3WlomxpwWuePHY6JpaBRJkY2f6awHkwkOjWgUucomPBvbCRYBARKdcXg9zn/a+1xC lvKQ== X-Forwarded-Encrypted: i=1; AJvYcCV9uod4fUF4PJHFYhBG63KE1jSifLhmKZXzUBArOB79CexCO/48c3Qcco2bkcxfOEsUPU4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzjlhjapm84ZaZCn1ZX0JcGQPSd0unIf0bHoXumXrtrVMAxdaLz DMDuCHshpCgEeJ84r+56pTrbwCB9Z3kSOnMuGXfXg8Xgc2wTmdCjxQ2bnKXYHI+J6WRHIjhXJzJ Fh39zbPaJl89rq1rjlm99EO20p2ZDBXDVb+gfSrezCVzcGIH46Q== X-Received: by 2002:a5d:58d2:0:b0:374:ca16:e09b with SMTP id ffacd0b85a97d-37ea21370eamr10229418f8f.9.1729611034107; Tue, 22 Oct 2024 08:30:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0zz73eNEgDwtK6KpTgteNC4JY1ou4UN+CqrAjVjAKfCV29EIzHazgxXKj9Qr93aNf7MnbxA== X-Received: by 2002:a5d:58d2:0:b0:374:ca16:e09b with SMTP id ffacd0b85a97d-37ea21370eamr10229386f8f.9.1729611033728; Tue, 22 Oct 2024 08:30:33 -0700 (PDT) Received: from ?IPV6:2a0d:3344:1b73:a910::f71? ([2a0d:3344:1b73:a910::f71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0a488edsm6862221f8f.31.2024.10.22.08.30.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 22 Oct 2024 08:30:33 -0700 (PDT) Message-ID: <0b779b4d-d2d3-499e-abf9-4eae4806316b@redhat.com> Date: Tue, 22 Oct 2024 17:30:28 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net] Drop packets with invalid headers to prevent KMSAN infoleak To: Daniel Yang , Martin KaFai Lau Cc: Daniel Borkmann , John Fastabend , Alexei Starovoitov , Andrii Nakryiko , Eduard Zingerman , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "open list:BPF [NETWORKING] (tcx & tc BPF, sock_addr)" , "open list:BPF [NETWORKING] (tcx & tc BPF, sock_addr)" , open list , syzbot+346474e3bf0b26bd3090@syzkaller.appspotmail.com References: <20241019071149.81696-1-danielyangkang@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/22/24 03:37, Daniel Yang wrote: > Are there any possible unexpected issues that can be caused by this? This patch is apparently the cause of BPF self-tests failures: test_empty_skb:FAIL:ret: veth ETH_HLEN+1 packet ingress [redirect_ingress] unexpected ret: veth ETH_HLEN+1 packet ingress [redirect_ingress]: actual -34 != expected 0 test_empty_skb:PASS:err: veth ETH_HLEN+1 packet ingress [redirect_egress] 0 nsec test_empty_skb:FAIL:ret: veth ETH_HLEN+1 packet ingress [redirect_egress] unexpected ret: veth ETH_HLEN+1 packet ingress [redirect_egress]: actual -34 != expected 1 Before submitting an eventual next revision, please very that BPF self-tests are happy. Thanks, Paolo