From: Daniel Borkmann <daniel@iogearbox.net>
To: Ilya Leoshkevich <iii@linux.ibm.com>,
Alexei Starovoitov <ast@kernel.org>
Cc: bpf@vger.kernel.org, Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH bpf-next] btf: do not use CONFIG_OUTPUT_FORMAT
Date: Wed, 21 Aug 2019 17:22:18 +0200 [thread overview]
Message-ID: <0c16ca75-1a8c-d8a5-e485-4bd9fc51dcd4@iogearbox.net> (raw)
In-Reply-To: <20190820112939.84249-1-iii@linux.ibm.com>
On 8/20/19 1:29 PM, Ilya Leoshkevich wrote:
> Building s390 kernel with CONFIG_DEBUG_INFO_BTF fails, because
> CONFIG_OUTPUT_FORMAT is not defined. As a matter of fact, this variable
> appears to be x86-only, so other arches might be affected as well.
>
> Fix by obtaining this value from objdump output, just like it's already
> done for bin_arch. The exact objdump invocation is "inspired" by
> arch/powerpc/boot/wrapper.
>
> Also, use LANG=C for the existing bin_arch objdump invocation to avoid
> potential build issues on systems with non-English locale.
>
> Fixes: 341dfcf8d78e ("btf: expose BTF info through sysfs")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
LGTM, applied, thanks!
prev parent reply other threads:[~2019-08-21 15:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 11:29 [PATCH bpf-next] btf: do not use CONFIG_OUTPUT_FORMAT Ilya Leoshkevich
2019-08-21 15:22 ` Daniel Borkmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c16ca75-1a8c-d8a5-e485-4bd9fc51dcd4@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=iii@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox