From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 769D2C433EF for ; Mon, 4 Jul 2022 17:14:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231465AbiGDROC (ORCPT ); Mon, 4 Jul 2022 13:14:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56866 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230064AbiGDROB (ORCPT ); Mon, 4 Jul 2022 13:14:01 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 47953267D for ; Mon, 4 Jul 2022 10:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1656954838; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dNFZBk2MReDVOF2gT6UYM02hb0KdZvS6at3FbBoI3pM=; b=PArGwWa2AIQ6Ws1O5kEobm8vkhA56MI4clSOkzrGxO95KE2Gq1cwLIstvzQBcdcLp5J0gv gOvoUeytuZne1cFZtZVvRzkMet/xX64+OEELCNHWKn+ET7JdnoEp9yx3pQwdI7eW1buQGq 4D3EiAop7tfEcvq85JflVW/9YC2DXMU= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-121-f160-yWZPIGm_TuTC5_tlw-1; Mon, 04 Jul 2022 13:13:57 -0400 X-MC-Unique: f160-yWZPIGm_TuTC5_tlw-1 Received: by mail-lf1-f70.google.com with SMTP id bi38-20020a0565120ea600b0047f640eaee0so3253233lfb.4 for ; Mon, 04 Jul 2022 10:13:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:message-id:date:mime-version:user-agent:cc :subject:content-language:to:references:in-reply-to :content-transfer-encoding; bh=dNFZBk2MReDVOF2gT6UYM02hb0KdZvS6at3FbBoI3pM=; b=KEROXKMUq0T0+DobGz7NHb7sEBOmmf2I0oxTFplJkwg6fuU3djvIuIH/mgJMeGUrPn bFFppzowPXnixAbqyJu23b93mibtFHGRaCEvD2GGe0qU0+ZRfNPRqtSI/SP0zvNLgLXN nOycn0HpHhcDAAFayBke/8L5YB0mdag1klvApMimpgXTSy5/zKL1GxLMvIhryST91Dx6 msBAiwAm2L35gO6Q9hEHj11xnoskWAcM73no83CQR18anfZuS5DEnNofqWnucZGFWTnD I140wL95GRjQqR1RPUTvQBNC026eKpMsqZUDr5GKGFR/GLYVDq1AJoqnYmtIdh9kOagD VhWQ== X-Gm-Message-State: AJIora93bzQfxRXkx+eJ8aYakMHM/nV7DaIE8eCayy3oL7zCSQ01vfCZ gm5o3FiKeDhu+Cg4bzuOWdmanyIS+Nn10DrBKqVJdbv56lUQ9ZudeBOggdZebddHXK3pU2oQr4M ikGj6cc0j5DEf X-Received: by 2002:a2e:b751:0:b0:25b:da59:96b9 with SMTP id k17-20020a2eb751000000b0025bda5996b9mr16564734ljo.176.1656954835579; Mon, 04 Jul 2022 10:13:55 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tHu1DJfF7/r9dEXd50aOLye631DC1z4l08yWjIoREL+G9uEz5rjyOO5svoU/MfRlDuSC4GRQ== X-Received: by 2002:a2e:b751:0:b0:25b:da59:96b9 with SMTP id k17-20020a2eb751000000b0025bda5996b9mr16564722ljo.176.1656954835371; Mon, 04 Jul 2022 10:13:55 -0700 (PDT) Received: from [192.168.0.50] (87-59-106-155-cable.dk.customer.tdc.net. [87.59.106.155]) by smtp.gmail.com with ESMTPSA id j13-20020ac253ad000000b0047f7f4cb583sm5200739lfh.288.2022.07.04.10.13.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Jul 2022 10:13:54 -0700 (PDT) From: Jesper Dangaard Brouer X-Google-Original-From: Jesper Dangaard Brouer Message-ID: <0cd3fd67-e179-7c27-a74f-255a05359941@redhat.com> Date: Mon, 4 Jul 2022 19:13:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Cc: brouer@redhat.com, John Fastabend , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Larysa Zaremba , Michal Swiatkowski , Jesper Dangaard Brouer , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jesse Brandeburg , Yajun Deng , Willem de Bruijn , bpf@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xdp-hints@xdp-project.net Subject: Re: [xdp-hints] Re: [PATCH RFC bpf-next 00/52] bpf, xdp: introduce and use Generic Hints/metadata Content-Language: en-US To: Alexander Lobakin , =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= References: <20220628194812.1453059-1-alexandr.lobakin@intel.com> <62bbedf07f44a_2181420830@john.notmuch> <87iloja8ly.fsf@toke.dk> <20220704154440.7567-1-alexandr.lobakin@intel.com> In-Reply-To: <20220704154440.7567-1-alexandr.lobakin@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 04/07/2022 17.44, Alexander Lobakin wrote: >> Agreed. This incremental approach is basically what Jesper's >> simultaneous series makes a start on, AFAICT? Would be nice if y'all >> could converge the efforts :) > > I don't know why at some point Jesper decided to go on his own as he > for sure was using our tree as a base for some time, dunno what > happened then. Regarding these two particular submissions, I didn't > see Jesper's RFC when sending mine, only after when I went to read > some stuff. > Well, I have written to you (offlist) that the git tree didn't compile, so I had a hard time getting it into a working state. We had a ping-pong of stuff to fix, but it wasn't and you basically told me to switch to using LLVM to compile your kernel tree, I was not interested in doing that. I have looked at the code in your GitHub tree, and decided that it was an over-engineered approach IMHO. Also simply being 52 commits deep without having posted this incrementally upstream were also a non-starter for me, as this isn't the way-to-work upstream. To get the ball rolling, I have implemented the base XDP-hints support here[1] with only 9 patches (including support for two drivers). IMHO we need to start out small and not intermix these huge refactoring patches. E.g. I'm not convinced renaming net/{core/xdp.c => bpf/core.c} is an improvement. -Jesper [1] https://lore.kernel.org/bpf/165643378969.449467.13237011812569188299.stgit@firesoul/