From: Mor Bar-Gabay <morx.bar.gabay@intel.com>
To: Joe Damato <jdamato@fastly.com>, <netdev@vger.kernel.org>
Cc: <vitaly.lifshits@intel.com>, <avigailx.dahan@intel.com>,
<anthony.l.nguyen@intel.com>, <stable@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"open list:XDP (eXpress Data Path)" <bpf@vger.kernel.org>,
"moderated list:INTEL ETHERNET DRIVERS"
<intel-wired-lan@lists.osuosl.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix XSK queue NAPI ID mapping
Date: Tue, 25 Mar 2025 18:23:47 +0200 [thread overview]
Message-ID: <0cee0610-19e7-4f25-9f27-86908834f36d@intel.com> (raw)
In-Reply-To: <20250305180901.128286-1-jdamato@fastly.com>
On 05/03/2025 20:09, Joe Damato wrote:
> In commit b65969856d4f ("igc: Link queues to NAPI instances"), the XSK
> queues were incorrectly unmapped from their NAPI instances. After
> discussion on the mailing list and the introduction of a test to codify
> the expected behavior, we can see that the unmapping causes the
> check_xsk test to fail:
>
> NETIF=enp86s0 ./tools/testing/selftests/drivers/net/queues.py
>
> [...]
> # Check| ksft_eq(q.get('xsk', None), {},
> # Check failed None != {} xsk attr on queue we configured
> not ok 4 queues.check_xsk
>
> After this commit, the test passes:
>
> ok 4 queues.check_xsk
>
> Note that the test itself is only in net-next, so I tested this change
> by applying it to my local net-next tree, booting, and running the test.
>
> Cc: stable@vger.kernel.org
> Fixes: b65969856d4f ("igc: Link queues to NAPI instances")
> Signed-off-by: Joe Damato <jdamato@fastly.com>
> Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
> ---
> drivers/net/ethernet/intel/igc/igc_xdp.c | 2 --
> 1 file changed, 2 deletions(-)
>
Tested-by: Mor Bar-Gabay <morx.bar.gabay@intel.com>
prev parent reply other threads:[~2025-03-25 16:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 18:09 [PATCH iwl-net] igc: Fix XSK queue NAPI ID mapping Joe Damato
2025-03-05 19:15 ` Gerhard Engleder
2025-03-06 16:27 ` florian
2025-03-06 16:45 ` Joe Damato
2025-03-06 18:31 ` Tony Nguyen
2025-03-07 21:37 ` Tony Nguyen
2025-03-25 16:23 ` Mor Bar-Gabay [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cee0610-19e7-4f25-9f27-86908834f36d@intel.com \
--to=morx.bar.gabay@intel.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=avigailx.dahan@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jdamato@fastly.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=stable@vger.kernel.org \
--cc=vitaly.lifshits@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox