Re: [PATCH bpf-next 1/5] bpf: Add KF_ACQUIRE and KF_RELEASE support for iterators

[Eduard Zingerman <eddyz87@gmail.com>]

On Fri, 2026-02-20 at 01:05 +0000, Puranjay Mohan wrote:
> On Thu, Feb 19, 2026 at 8:37 PM Eduard Zingerman <eddyz87@gmail.com> wrote:
> > 
> > On Wed, 2026-02-18 at 10:25 -0800, Puranjay Mohan wrote:
> > 
> > [...]
> > 
> > > @@ -13797,7 +13826,7 @@ static int check_kfunc_args(struct bpf_verifier_env *env, struct
> > > bpf_kfunc_call_
> > >               }
> > >       }
> > > 
> > > -     if (is_kfunc_release(meta) && !meta->release_regno) {
> > > +     if (is_kfunc_release(meta) && !meta->release_regno && !meta->has_iter_arg) {
> > 
> > This makes the check too strict, right?
> > E.g. for most of the release kfuncs there would be no iter arg,
> > hence the check won't ever be true for those kfuncs.
> > Do we have tests for this check?
> > Either we don't have the tests or the check itself is redundant.
> 
> A release kfunc should either have meta->release_regno set or it
> should take an __iter arg, that is what this is checking. If we leave
> it like it was then every release function that take __iter would fail
> her.

Oh, right, I missed the point here.

> But anyway I will be doing it the better way how Mykyta
> Suggested, so this will be gone.