From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1330DC433EF for ; Tue, 10 May 2022 12:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241373AbiEJMtf (ORCPT ); Tue, 10 May 2022 08:49:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241949AbiEJMte (ORCPT ); Tue, 10 May 2022 08:49:34 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25BBF5521C for ; Tue, 10 May 2022 05:45:34 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id v10so14531195pgl.11 for ; Tue, 10 May 2022 05:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=81CmoXK8W2fMc2E/XpNylErNEPWG7PeFWSGfTvENHek=; b=BuizLo0eMVf1CFKzq5z5mJXXTCdmsbZnthwaSpGZvyOinz0zK1oVrwY+RjDSbz0lsj W4/gcD2GsatA2CltDPm42940C9Zx8OlEiXWEDruJeUP+scX4B4Dn/BR45LSBkgx0ha/1 1lof9Sxe/0+TSOSmg+ZbSpzVPPfdI8D1n/IK23ovFovWMObnth4tWgSXWT44+EFOD5cw YRdLOnhCKKUDhjj1PBpvvrU/SLEYIvonvF8JuhoBcVkVWvziCCxnA6XbN07WU1oTTJuX 9N9BICkQtsDiH2S5IvrqAAzmp2SqDTXhUfx7lB75VtVwJ+wJsJW+JGZukF4rewQyhJ7E HF3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=81CmoXK8W2fMc2E/XpNylErNEPWG7PeFWSGfTvENHek=; b=HySCVq93TNpDD0mqp+JQAYk+1/Ltgo/KNO58i2bHD1H1uOyMSzpVwis6gEaiDAj/k0 li544LquAAl0XkCCgwAnrySrry8FK3dxWIDHmeeIjsZpV8fut0hc/8tM17srK4HiyaMW ib+xUcD1t65Bl7VzufRKAZthVzd/iwsaRQI3a/6Ux6I/y9ysaaiDVcirdzbtePuY6xOI 4ibCWEd0AYHPqNZ5Gpp78rhZTeVpxinTj7BpsGbRkMiMaud7Xx2zZmHaqIxUC0L4v2f0 nTB/8FtbQvMkjPITYmcCjapSXEhollBKjEWwkdGFdMSPhLtBfaLVvcxgq7nh+uYTA6Lt 6hdQ== X-Gm-Message-State: AOAM531sYx6ZJGwMxpM3i1YkfH1saGdpTSPugc8NYlI1JBiUQDqagtHS Zt2OzZv4pHZCp5EVIQjZTh67crirYV8iZEoO X-Google-Smtp-Source: ABdhPJww7Eg4/Zxst2GZrQrVNwauUtpxNCsfNjZ19FUR133ytWOXTk+q1xGx0v1s2BhN+B7mV7yS+A== X-Received: by 2002:a63:2c8a:0:b0:3aa:86ea:f2c9 with SMTP id s132-20020a632c8a000000b003aa86eaf2c9mr16916062pgs.46.1652186733527; Tue, 10 May 2022 05:45:33 -0700 (PDT) Received: from [192.168.1.100] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id q187-20020a632ac4000000b003c14af5063fsm10345438pgq.87.2022.05.10.05.45.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 May 2022 05:45:32 -0700 (PDT) Message-ID: <0e1b3d10-ae79-f987-187e-58109441ccee@kernel.dk> Date: Tue, 10 May 2022 06:45:31 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [syzbot] KASAN: use-after-free Read in bio_poll Content-Language: en-US To: Christoph Hellwig , Ming Lei Cc: syzbot , andrii@kernel.org, ast@kernel.org, bpf@vger.kernel.org, daniel@iogearbox.net, john.fastabend@gmail.com, kafai@fb.com, kpsingh@kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, songliubraving@fb.com, syzkaller-bugs@googlegroups.com, yhs@fb.com References: <00000000000029572505de968021@google.com> <20220510055039.GA10576@lst.de> From: Jens Axboe In-Reply-To: <20220510055039.GA10576@lst.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On 5/9/22 11:50 PM, Christoph Hellwig wrote: > On Tue, May 10, 2022 at 08:13:58AM +0800, Ming Lei wrote: >>> Guys, should we just queue: >>> >>> ommit 9650b453a3d4b1b8ed4ea8bcb9b40109608d1faf >>> Author: Ming Lei >>> Date: Wed Apr 20 22:31:10 2022 +0800 >>> >>> block: ignore RWF_HIPRI hint for sync dio >>> >>> up for 5.18 and stable? >> >> I am fine with merging to 5.18 & stable. > > I'm fine, too. But are we sure this actually is one and the same > issue? Otherwise I'll try to find some time to feed it to syzbot > first. I re-wrote the reproducer a bit and can reproduce it, so I can certainly test a backport. But yes, I was skeptical on this being the same issue too. My initial reaction was that this is likely due to the bio being "downgraded" from polled to IRQ driven, and hence completes without an extra reference before the bio_poll() is done on it. Which is not the issue described in the referenced commit. -- Jens Axboe