From: Eduard Zingerman <eddyz87@gmail.com>
To: Shung-Hsi Yu <shung-hsi.yu@suse.com>,
Xu Kuohai <xukuohai@huaweicloud.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Yonghong Song <yonghong.song@linux.dev>,
KP Singh <kpsingh@kernel.org>,
Roberto Sassu <roberto.sassu@huawei.com>,
Matt Bobrowski <mattbobrowski@google.com>,
Yafang Shao <laoar.shao@gmail.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
"Jose E . Marchesi" <jose.marchesi@oracle.com>,
James Morris <jamorris@linux.microsoft.com>,
Kees Cook <kees@kernel.org>,
Brendan Jackman <jackmanb@google.com>,
Florent Revest <revest@google.com>
Subject: Re: [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND
Date: Mon, 22 Jul 2024 11:47:55 -0700 [thread overview]
Message-ID: <0e46dcf652ff0b1168fc82e491c3d20eae18b21d.camel@gmail.com> (raw)
In-Reply-To: <wjvdnep2od4kf3f7fiteh73s4gnktcfsii4lbb2ztvudexiyqw@hxqowhgokxf3>
On Mon, 2024-07-22 at 20:57 +0800, Shung-Hsi Yu wrote:
[...]
> > As a nitpick, I think that it would be good to have some shortened
> > version of the derivation in the comments alongside the code.
>
> Agree it would. Will try to add a 2-4 sentence explanation.
>
> > (Maybe with a link to the mailing list).
>
> Adding a link to the mailing list seems out of the usual for comment in
> verifier.c though, and it would be quite long. That said, it would be
> nice to hint that there exists a more verbose version of the
> explanation.
>
> Maybe an explicit "see commit for the full detail" at the end of
> the added comment?
Tbh, I find bounds deduction code extremely confusing.
Imho, having lengthy comments there is a good thing.
next prev parent reply other threads:[~2024-07-22 18:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 11:00 [PATCH bpf-next v2 0/9] Add BPF LSM return value range check, BPF part Xu Kuohai
2024-07-19 11:00 ` [PATCH bpf-next v2 1/9] bpf, lsm: Add disabled BPF LSM hook list Xu Kuohai
2024-07-19 11:00 ` [PATCH bpf-next v2 2/9] bpf, lsm: Add check for BPF LSM return value Xu Kuohai
2024-07-19 11:00 ` [PATCH bpf-next v2 3/9] bpf: Prevent tail call between progs attached to different hooks Xu Kuohai
2024-07-19 11:00 ` [PATCH bpf-next v2 4/9] bpf: Fix compare error in function retval_range_within Xu Kuohai
2024-07-19 11:00 ` [PATCH bpf-next v2 5/9] bpf, verifier: improve signed ranges inference for BPF_AND Xu Kuohai
2024-07-22 7:13 ` Eduard Zingerman
2024-07-22 12:57 ` Shung-Hsi Yu
2024-07-22 18:47 ` Eduard Zingerman [this message]
2024-07-23 0:48 ` Alexei Starovoitov
2024-07-23 6:36 ` Shung-Hsi Yu
2024-07-23 7:07 ` Shung-Hsi Yu
2024-07-24 1:17 ` Alexei Starovoitov
2024-07-19 11:00 ` [PATCH bpf-next v2 6/9] selftests/bpf: Avoid load failure for token_lsm.c Xu Kuohai
2024-07-19 11:00 ` [PATCH bpf-next v2 7/9] selftests/bpf: Add return value checks for failed tests Xu Kuohai
2024-07-19 11:00 ` [PATCH bpf-next v2 8/9] selftests/bpf: Add test for lsm tail call Xu Kuohai
2024-07-19 11:00 ` [PATCH bpf-next v2 9/9] selftests/bpf: Add verifier tests for bpf lsm Xu Kuohai
2024-07-22 19:57 ` [PATCH bpf-next v2 0/9] Add BPF LSM return value range check, BPF part bot+bpf-ci
2024-07-23 0:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e46dcf652ff0b1168fc82e491c3d20eae18b21d.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=iii@linux.ibm.com \
--cc=jackmanb@google.com \
--cc=jamorris@linux.microsoft.com \
--cc=jose.marchesi@oracle.com \
--cc=kees@kernel.org \
--cc=kpsingh@kernel.org \
--cc=laoar.shao@gmail.com \
--cc=linux-security-module@vger.kernel.org \
--cc=mattbobrowski@google.com \
--cc=netdev@vger.kernel.org \
--cc=revest@google.com \
--cc=roberto.sassu@huawei.com \
--cc=shung-hsi.yu@suse.com \
--cc=xukuohai@huaweicloud.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox