From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A00517AE11; Thu, 30 Oct 2025 08:05:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761811561; cv=none; b=A17rChyBtDPD795qhm0JSfE7CQlJwuz0bmACTnFb4NvY48DVPAjVsb3E7vQv1AHtfpyUvmEi+rDGAtFiZ0wqBW0y+5qBeFOx1+A6tucY6FNl4/Mor345+UH05V976XLVxAY/atnmm97BfSfqnsZWsKDj7JP6WJXFttx8R8fVzFQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761811561; c=relaxed/simple; bh=Op1t4LLfAXhJLesSQQ0Zr9Tb4KUF5kV6yD/hPL9PUSI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Pw7LC46vPp7p8X179FovFtlvDqJ2n9d6KZVros8cus0yUQcvQsNj2VkxfoxwDaQb5E2SpKUGJJqf/gRKV1ngEzeXjZsXZK9LN2xQfYvehtRqzN7bl5B20uidSzZnt+zLiV9B5XBDuc0oS+JFKpYHdlW9WGFHg/vhHrBte5QCEx0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=jlsLX77L; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="jlsLX77L" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id BB3A81A1781; Thu, 30 Oct 2025 08:05:56 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 7DDD96068C; Thu, 30 Oct 2025 08:05:56 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id BD087102F2130; Thu, 30 Oct 2025 09:05:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1761811555; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:content-language:in-reply-to:references; bh=yhO0zoxEkB9DzrUVoWIN7bjo6McuuEao4alqEu6uLBQ=; b=jlsLX77LeQNohInoJWs+ecJrRdx6EBTro8CMxvC3JPE0B4chG8p7w/UusCVGAaMnr+1by2 rFS5EtZPlcXC37k9JwKwOBoYt/KYglMziIUjDzOeGvfy321aj9dfJZF9TnzJcKpv8gTVZw rgLMYpNIMH3sL363P1TBpmaGeu8RfX01IID9c9hEo0zVBeGeBD5S9L0Csk06GDMAt5wAWR orRWpcqnFmdeK7ZqniILIj0pWgsfiFoZfrm98KdvQUeXP/V3MSLz2BA0/sAmWDaqW+xkM8 gJ2vmYsvzbnERCIb3kxPlDOb25QcesuUIsBpG5o16ja0PzlrIZZ1T59M42FzBQ== Message-ID: <0e576e3d-7e77-43ec-8ec2-5867dcb44960@bootlin.com> Date: Thu, 30 Oct 2025 09:05:47 +0100 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v6 00/15] selftests/bpf: Integrate test_xsk.c to test_progs framework To: Alexei Starovoitov Cc: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Mykola Lysenko , Shuah Khan , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , Thomas Petazzoni , Alexis Lothore , Network Development , bpf , "open list:KERNEL SELFTEST FRAMEWORK" , LKML References: <20251029-xsk-v6-0-5a63a64dff98@bootlin.com> From: Bastien Curutchet Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Last-TLS-Session-Version: TLSv1.3 Hi, On 10/29/25 7:54 PM, Alexei Starovoitov wrote: > On Wed, Oct 29, 2025 at 6:52 AM Bastien Curutchet (eBPF Foundation) > wrote: >> >> Hi all, >> >> The test_xsk.sh script covers many AF_XDP use cases. The tests it runs >> are defined in xksxceiver.c. Since this script is used to test real >> hardware, the goal here is to leave it as it is, and only integrate the >> tests that run on veth peers into the test_progs framework. >> >> I've looked into what could improve the speed in the CI: >> - some tests are skipped when run on veth peers in a VM (because they >> rely on huge page allocation or HW rings). This skipping logic still >> takes some time and can be easily avoided. >> - the TEARDOWN test is quite long (several seconds on its own) because >> it runs the same test 10 times in a row to ensure the teardown process >> works properly >> >> With theses tests fully skipped in the CI and the veth setup done only >> once for each mode (DRV / SKB), the execution time is reduced to about 5 >> seconds on my setup. >> ``` >> $ tools/testing/selftests/bpf/vmtest.sh -d $HOME/ebpf/output-regular/ -- time ./test_progs -t xsk >> [...] >> real 0m 5.04s >> user 0m 0.38s >> sys 0m 1.61s > > This is fine. I see > Summary: 2/48 PASSED, 0 SKIPPED, 0 FAILED > > real 0m8.165s > user 0m1.795s > sys 0m4.740s > > on debug kernel with kasan which is ok. > > But it conflicts with itself :( > > $ test_progs -j -t xsk > > All error logs: > setup_veth:FAIL:ip link add veth0 numtxqueues 4 numrxqueues 4 type > veth peer name veth1 numtxqueues 4 numrxqueues 4 unexpected error: 512 > (errno 2) > test_xsk_drv:FAIL:setup veth unexpected error: -1 (errno 2) > #664 xsk_drv:FAIL > Summary: 1/24 PASSED, 0 SKIPPED, 1 FAILED > > Pls fix the parallel run and not by adding "_serial", of course. Oups, in my quest for speed I removed the 'test_ns' prefix. It didn't seem necessary since all tests are run at once, but I forgot about parallel execution between the DRV and SKB modes.. Sorry about this, I'll put back the 'test_ns' prefix. It will be a good opportunity to address some of the AI feedback I received. Best regards, Bastien