From: Martin KaFai Lau <martin.lau@linux.dev>
To: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Kuniyuki Iwashima <kuni1840@gmail.com>
Subject: BUG? flaky "migrate_reuseport/IPv4 TCP_NEW_SYN_RECV reqsk_timer_handler" test
Date: Thu, 21 Mar 2024 18:39:53 -0700 [thread overview]
Message-ID: <0edaead1-b20b-4222-9ed5-4347efcebbc2@linux.dev> (raw)
Hi Kuniyuki,
The bpf CI has recently hit failure in the "migrate_reuseport/IPv4
TCP_NEW_SYN_RECV" test. It does not always fail but becomes more flaky recently:
https://github.com/kernel-patches/bpf/actions/runs/8354884067/job/22869153115
It could be due to some slowness in the bpf CI environment but failing because
of environment slowness is still not expected.
I took a very quick look. It seems like the test depends on the firing of the
timer's handler "reqsk_timer_handler()", so there is a sleep(1) in the test.
May be the timer fired slower and the test failed? If that is the case, it may
help to directly trace the reqsk_timer_handler() and wait for enough time to
ensure it is called.
This test has been temporarily disabled for now
(https://github.com/kernel-patches/vmtest/blob/master/ci/vmtest/configs/DENYLIST).
Once you have a fix, we can re-enable it again to ensure this migrate feature
will not regress.
Thanks,
Martin
next reply other threads:[~2024-03-22 1:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 1:39 Martin KaFai Lau [this message]
2024-03-22 1:54 ` BUG? flaky "migrate_reuseport/IPv4 TCP_NEW_SYN_RECV reqsk_timer_handler" test Jakub Kicinski
2024-03-22 18:08 ` Kuniyuki Iwashima
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0edaead1-b20b-4222-9ed5-4347efcebbc2@linux.dev \
--to=martin.lau@linux.dev \
--cc=bpf@vger.kernel.org \
--cc=kuni1840@gmail.com \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox