From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EE/+G3bP" Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4DF09135 for ; Tue, 5 Dec 2023 15:22:34 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2c9ef682264so49645131fa.3 for ; Tue, 05 Dec 2023 15:22:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701818552; x=1702423352; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=5YsTmqDpVro3SV4NaoGaBMEi0qoVDpmEZLmvtvyYRVc=; b=EE/+G3bPfGxAE2CosQFZqvSAVhgAMQWZoRayFWfZwpwgT/B7A39gLo0Nrzd28FnlY6 7YRT3dYmRsDE5vBGqPfuzYalex7pRHq6tOTOPZnHtoCC4IJ2zCxJ4o7ufR0BdFDIB9c4 MqtfPs7XQjxOPJ4EaJ1ObepEpCZqNOhvsqhfvB7y4CjeRStj7FZWB4SpYP5grR5tpPkG kw+hwk5T3NABirbrs6n836VxxDwVHamg6HleX35Erygw48x6Vvs6PEPPZtXl1AhzXoN7 +STHdPMLhz+X0mdTrNayA4HYv3KgDO1BYVcho7kb4sidxzx4kpHaV4+RsxAiM/McuxW6 2dgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701818552; x=1702423352; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5YsTmqDpVro3SV4NaoGaBMEi0qoVDpmEZLmvtvyYRVc=; b=mVAM0x+3LC9HTvIXkelz6KUit9MBVkjmKdkSGFS7zikxQfztIkpNdg4x7Vf4bkwLeX W+7UX+Feibi8SFX/S8rSMu9fwRJpjKVCtXgUVpykg6CjL3epQY7FJKj3R142aWPlQazu XmloggfcbVsaVo3Yh0h3p/ciQF0vXxDMsyOjio7YsWYWvplxjaYFTkn6uzWGUo7d+1bq ChfoAe58SUnWnntF05gwyhq6IIzTYnMPNe5d1UTl2Y2725D2mQ7RNQKXIYdO+qtGJL96 U3Ea/WwFZmS/mt4pWWYA9yeOGSvxzcJ2y5Tqdc3zx1vGer6P9mwzecQln7+vhQ8s1454 dbBg== X-Gm-Message-State: AOJu0YxtqJVEoZTYeKvijSqAto2f6mMTkzxV80NvVNiL012jnMiVe013 36wzcBUCHeJKzXIyDkd/KXI= X-Google-Smtp-Source: AGHT+IE33h5qNn87BK71xq++QktwfRfknPuCf/1WMBSxBhqvAgyH/jzccVJ3M00nsFgM9uXzOJXLmA== X-Received: by 2002:a2e:99da:0:b0:2c9:ef47:f670 with SMTP id l26-20020a2e99da000000b002c9ef47f670mr16786ljj.52.1701818552543; Tue, 05 Dec 2023 15:22:32 -0800 (PST) Received: from [192.168.1.95] (host-176-36-0-241.b024.la.net.ua. [176.36.0.241]) by smtp.gmail.com with ESMTPSA id m10-20020a2e97ca000000b002ca031359a3sm827662ljj.51.2023.12.05.15.22.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 15:22:32 -0800 (PST) Message-ID: <0f3d582a2ec646c36625325843aef301932d31b4.camel@gmail.com> Subject: Re: [PATCH bpf-next 11/13] bpf: add dynptr global subprog arg tag support From: Eduard Zingerman To: Andrii Nakryiko , bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net, martin.lau@kernel.org Cc: kernel-team@meta.com Date: Wed, 06 Dec 2023 01:22:25 +0200 In-Reply-To: <20231204233931.49758-12-andrii@kernel.org> References: <20231204233931.49758-1-andrii@kernel.org> <20231204233931.49758-12-andrii@kernel.org> Autocrypt: addr=eddyz87@gmail.com; prefer-encrypt=mutual; keydata=mQGNBGKNNQEBDACwcUNXZOGTzn4rr7Sd18SA5Wv0Wna/ONE0ZwZEx+sIjyGrPOIhR14/DsOr3ZJer9UJ/WAJwbxOBj6E5Y2iF7grehljNbLr/jMjzPJ+hJpfOEAb5xjCB8xIqDoric1WRcCaRB+tDSk7jcsIIiMish0diTK3qTdu4MB6i/sh4aeFs2nifkNi3LdBuk8Xnk+RJHRoKFJ+C+EoSmQPuDQIRaF9N2m4yO0eG36N8jLwvUXnZzGvHkphoQ9ztbRJp58oh6xT7uH62m98OHbsVgzYKvHyBu/IU2ku5kVG9pLrFp25xfD4YdlMMkJH6l+jk+cpY0cvMTS1b6/g+1fyPM+uzD8Wy+9LtZ4PHwLZX+t4ONb/48i5AKq/jSsb5HWdciLuKEwlMyFAihZamZpEj+9n91NLPX4n7XeThXHaEvaeVVl4hfW/1Qsao7l1YjU/NCHuLaDeH4U1P59bagjwo9d1n5/PESeuD4QJFNqW+zkmE4tmyTZ6bPV6T5xdDRHeiITGc00AEQEAAbQkRWR1YXJkIFppbmdlcm1hbiA8ZWRkeXo4N0BnbWFpbC5jb20+iQHUBBMBCgA+FiEEx+6LrjApQyqnXCYELgxleklgRAkFAmKNNQECGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQLgxleklgRAlWZAv/cJ5v3zlEyP0/jMKQBqbVCCHTirPEw+nqxbkeSO6r2FUds0NnGA9a6NPOpBH+qW7a6+n6q3sIbvH7jlss4pzLI7LYlDC6z+egTv7KR5X1xFrY1uR5UGs1beAjnzYeV2hK4yqRUfygsT0Wk5e4FiNBv4+DUZ8r0cNDkO6swJxU55DO21mcteC147+4aDoHZ40R0tsAu+brDGSSoOPpb0RWVsEf9XOBJqWWA+T7mluw nYzhLWGcczc6J71q1Dje0l5vIPaSFOgwmWD4DA+WvuxM/shH4rtWeodbv iCTce6yYIygHgUAtJcHozAlgRrL0jz44cggBTcoeXp/atckXK546OugZPnl00J3qmm5uWAznU6T5YDv2vCvAMEbz69ib+kHtnOSBvR0Jb86UZZqSb4ATfwMOWe9htGTjKMb0QQOLK0mTcrk/TtymaG+T4Fsos0kgrxqjgfrxxEhYcVNW8v8HISmFGFbqsJmFbVtgk68BcU0wgF8oFxo7u+XYQDdKbI1uQGNBGKNNQEBDADbQIdo8L3sdSWGQtu+LnFqCZoAbYurZCmUjLV3df1b+sg+GJZvVTmMZnzDP/ADufcbjopBBjGTRAY4L76T2niu2EpjclMMM3mtrOc738Kr3+RvPjUupdkZ1ZEZaWpf4cZm+4wH5GUfyu5pmD5WXX2i1r9XaUjeVtebvbuXWmWI1ZDTfOkiz/6Z0GDSeQeEqx2PXYBcepU7S9UNWttDtiZ0+IH4DZcvyKPUcK3tOj4u8GvO3RnOrglERzNCM/WhVdG1+vgU9fXO83TB/PcfAsvxYSie7u792s/I+yA4XKKh82PSTvTzg2/4vEDGpI9yubkfXRkQN28w+HKF5qoRB8/L1ZW/brlXkNzA6SveJhCnH7aOF0Yezl6TfX27w1CW5Xmvfi7X33V/SPvo0tY1THrO1c+bOjt5F+2/K3tvejmXMS/I6URwa8n1e767y5ErFKyXAYRweE9zarEgpNZTuSIGNNAqK+SiLLXt51G7P30TVavIeB6s2lCt1QKt62ccLqUAEQEAAYkBvAQYAQoAJhYhBMfui64wKUMqp1wmBC4MZXpJYEQJBQJijTUBAhsMBQkDwmcAAAoJEC4MZXpJYEQJkRAMAKNvWVwtXm/WxWoiLnXyF2WGXKoDe5+itTLvBmKcV/b1OKZF1s90V7WfSBz712eFAynEzyeezPbwU8QBiTpZcHXwQni3IYKvsh7s t1iq+gsfnXbPz5AnS598ScZI1oP7OrPSFJkt/z4acEbOQDQs8aUqrd46PV jsdqGvKnXZxzylux29UTNby4jTlz9pNJM+wPrDRmGfchLDUmf6CffaUYCbu4FiId+9+dcTCDvxbABRy1C3OJ8QY7cxfJ+pEZW18fRJ0XCl/fiV/ecAOfB3HsqgTzAn555h0rkFgay0hAvMU/mAW/CFNSIxV397zm749ZNLA0L2dMy1AKuOqH+/B+/ImBfJMDjmdyJQ8WU/OFRuGLdqOd2oZrA1iuPIa+yUYyZkaZfz/emQwpIL1+Q4p1R/OplA4yc301AqruXXUcVDbEB+joHW3hy5FwK5t5OwTKatrSJBkydSF9zdXy98fYzGniRyRA65P0Ix/8J3BYB4edY2/w0Ip/mdYsYQljBY0A== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.1 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2023-12-04 at 15:39 -0800, Andrii Nakryiko wrote: > Add ability to pass a pointer to dynptr for global functions by using > btf_decl_tag("arg:dynptr") tag hint. This allows to have global subprogs > that accept and work with generic dynptrs that are created by caller. Why is this preferable to a check that parameter's BTF type is STRUCT 'bpf_dynptr'? [...]