From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout.efficios.com (smtpout.efficios.com [167.114.26.122]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 718041ACE94; Thu, 20 Jun 2024 15:04:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=167.114.26.122 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718895847; cv=none; b=obr7RXXVZhLhXe0dKp0IYU7ZRhIPciTtmBNiNUa8KFkAmBqhZfjcsYya2wjOcx+L7e17P42aKBn9nKvY58uXZTfFECmUkLFyDIckm3mpYe2IeC0Xqnm1m2uGRpFEuSG0fVlAdlsfgRhSPuiyjosWkumiGLLl3CSIA2eyf5dNQMk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718895847; c=relaxed/simple; bh=WuKsR5UCbBJdInJyClNe/aw+42aigHkyrGRbdfRklW0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LW59T9PYXC69U6ExGHONud7sAhADj0Gk3ATKgHzHE/wpSTGpayWmC/kt6K/rdvnDVsZpqveHjZyM0Sfy55gYYJYUGiA7nkCaETDjrweiGpMYcuoZsVct3w+p8StKSjO8y5FZNDPpoTnAsMHjqNlpLO3wc3yGwiaT58vCs2DP9OI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com; spf=pass smtp.mailfrom=efficios.com; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b=hVD1FHm7; arc=none smtp.client-ip=167.114.26.122 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=efficios.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=efficios.com header.i=@efficios.com header.b="hVD1FHm7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=efficios.com; s=smtpout1; t=1718895833; bh=WuKsR5UCbBJdInJyClNe/aw+42aigHkyrGRbdfRklW0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hVD1FHm7pxjswQzkufkpU1KL8KIbfAHlzLTn63xzLlja4Ii/JWN+UcyZVGQRTiuMB nvl3LSV7SRiOLsTXRgJiRearwY8pWFi0tb94QqS7axqABRoMzObOcROuqdpoy42pZG Cp6h73cn05YOSfJHPQu8mlshaOq7l7AD/8l101dHjIt/fjBOkWbUWdb9PoEjsuX5qc opcv40oOcqq2WAtV43C0XX3tpybKo2IOXHLvSIj1bdn7vr5eMxPGQD7urEotYxVfSz pkVlIjRO5yJbQZHAa1ytpUXwg7TL3AvRP4O6z1Qjv5A/g+mjn89ljZ878wfTEgR1n4 cU2jMPTVAPENQ== Received: from [172.16.0.134] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) by smtpout.efficios.com (Postfix) with ESMTPSA id 4W4kK45BBTz16rQ; Thu, 20 Jun 2024 11:03:52 -0400 (EDT) Message-ID: <10158845-ecbf-491e-bcde-a40453f8b94c@efficios.com> Date: Thu, 20 Jun 2024 11:04:53 -0400 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] tracing/ftrace: Add support for faultable tracepoints To: Peter Zijlstra , Michael Jeanson Cc: Steven Rostedt , Masami Hiramatsu , linux-kernel@vger.kernel.org, Alexei Starovoitov , Yonghong Song , "Paul E . McKenney" , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , bpf@vger.kernel.org, Joel Fernandes References: <20231120205418.334172-1-mathieu.desnoyers@efficios.com> <20231120205418.334172-3-mathieu.desnoyers@efficios.com> <20231120221524.GD8262@noisy.programming.kicks-ass.net> From: Mathieu Desnoyers Content-Language: en-US In-Reply-To: <20231120221524.GD8262@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-11-20 17:15, Peter Zijlstra wrote: > On Mon, Nov 20, 2023 at 03:54:15PM -0500, Mathieu Desnoyers wrote: >> @@ -380,8 +415,8 @@ static inline notrace int trace_event_get_offsets_##call( \ >> [...] > > I think something like the below (which is on top of the cleanup patch > in tip/locking/core) might just do... [ guard stuff ] Yes, we will apply those suggestions, thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com