BPF List
 help / color / mirror / Atom feed
From: Hengqi Chen <hengqi.chen@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>, Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH bpf-next 2/2 v2] selftests/bpf: Test bpf_skc_to_unix_sock() helper
Date: Tue, 19 Oct 2021 23:23:17 +0800	[thread overview]
Message-ID: <10abc62b-a263-b157-912f-363ae1f80a4c@gmail.com> (raw)
In-Reply-To: <CAADnVQLGfg=iMUi4oQtMzY9Y+j_pZtAAHQ_b8zO6wPaL6C0ooA@mail.gmail.com>

Thanks for the review.

On 10/19/21 9:46 AM, Alexei Starovoitov wrote:
> On Thu, Oct 7, 2021 at 7:14 AM Hengqi Chen <hengqi.chen@gmail.com> wrote:
>> +
>> +       sockaddr.sun_family = AF_UNIX;
>> +       strcpy(sockaddr.sun_path, sock_path);
> 
> please use strncpy.

Will do.

> 
>> +       len = sizeof(sockaddr);
>> +       unlink(sock_path);
> 
> please use abstract socket to avoid unlink and potential race.
> 

Will switch to abstract socket and update the BPF program.

  reply	other threads:[~2021-10-19 15:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-07 14:13 [PATCH bpf-next 0/2 v2] Add bpf_skc_to_unix_sock() helper Hengqi Chen
2021-10-07 14:13 ` [PATCH bpf-next 1/2 v2] bpf: " Hengqi Chen
2021-10-07 14:13 ` [PATCH bpf-next 2/2 v2] selftests/bpf: Test " Hengqi Chen
2021-10-19  1:46   ` Alexei Starovoitov
2021-10-19 15:23     ` Hengqi Chen [this message]
2021-10-19 17:02       ` Andrii Nakryiko
2021-10-20 13:41         ` Hengqi Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=10abc62b-a263-b157-912f-363ae1f80a4c@gmail.com \
    --to=hengqi.chen@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox