From: Eduard Zingerman <eddyz87@gmail.com>
To: Alan Maguire <alan.maguire@oracle.com>,
andrii@kernel.org, jolsa@kernel.org, acme@redhat.com,
quentin@isovalent.com
Cc: mykolal@fb.com, ast@kernel.org, daniel@iogearbox.net,
martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, houtao1@huawei.com, bpf@vger.kernel.org,
masahiroy@kernel.org, mcgrof@kernel.org, nathan@kernel.org
Subject: Re: [PATCH v5 bpf-next 8/9] libbpf,bpf: share BTF relocate-related code with kernel
Date: Fri, 31 May 2024 02:34:33 -0700 [thread overview]
Message-ID: <13fd222ca9f31055b35c55b4ebd2b8b578b741b1.camel@gmail.com> (raw)
In-Reply-To: <20240528122408.3154936-9-alan.maguire@oracle.com>
On Tue, 2024-05-28 at 13:24 +0100, Alan Maguire wrote:
> Share relocation implementation with the kernel. As part of this,
> we also need the type/string visitation functions so add them to a
> btf_common.c file that also gets shared with the kernel. Relocation
> code in kernel and userspace is identical save for the impementation
> of the reparenting of split BTF to the relocated base BTF and
> retrieval of BTF header from "struct btf"; these small functions
> need separate user-space and kernel implementations.
>
> One other wrinkle on the kernel side is we have to map .BTF.ids in
> modules as they were generated with the type ids used at BTF encoding
> time. btf_relocate() optionally returns an array mapping from old BTF
> ids to relocated ids, so we use that to fix up these references where
> needed for kfuncs.
>
> Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
> ---
I think we also need a test or a few tests to verify that ID sets are
converted correctly.
Acked-by: Eduard Zingerman <eddyz87@gmail.com>
next prev parent reply other threads:[~2024-05-31 9:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-28 12:23 [PATCH v5 bpf-next 0/9] bpf: support resilient split BTF Alan Maguire
2024-05-28 12:24 ` [PATCH v5 bpf-next 1/9] libbpf: add btf__distill_base() creating split BTF with distilled base BTF Alan Maguire
2024-05-30 19:58 ` Eduard Zingerman
2024-05-28 12:24 ` [PATCH v5 bpf-next 2/9] selftests/bpf: test distilled base, split BTF generation Alan Maguire
2024-05-30 20:23 ` Eduard Zingerman
2024-05-28 12:24 ` [PATCH v5 bpf-next 3/9] libbpf: split BTF relocation Alan Maguire
2024-05-31 2:22 ` Eduard Zingerman
2024-05-31 15:38 ` Alan Maguire
2024-05-31 18:44 ` Andrii Nakryiko
2024-06-01 7:56 ` Eduard Zingerman
2024-06-02 13:47 ` Alan Maguire
2024-05-31 18:21 ` Andrii Nakryiko
2024-05-28 12:24 ` [PATCH v5 bpf-next 4/9] selftests/bpf: extend distilled BTF tests to cover " Alan Maguire
2024-05-31 2:23 ` Eduard Zingerman
2024-05-28 12:24 ` [PATCH v5 bpf-next 5/9] libbpf: make btf_parse_elf process .BTF.base transparently Alan Maguire
2024-05-31 18:57 ` Andrii Nakryiko
2024-06-01 8:04 ` Eduard Zingerman
2024-05-28 12:24 ` [PATCH v5 bpf-next 6/9] resolve_btfids: handle presence of .BTF.base section Alan Maguire
2024-05-28 12:24 ` [PATCH v5 bpf-next 7/9] module, bpf: store BTF base pointer in struct module Alan Maguire
2024-05-28 18:27 ` Luis Chamberlain
2024-05-28 12:24 ` [PATCH v5 bpf-next 8/9] libbpf,bpf: share BTF relocate-related code with kernel Alan Maguire
2024-05-31 9:34 ` Eduard Zingerman [this message]
2024-05-31 16:13 ` Alan Maguire
2024-05-31 19:04 ` Andrii Nakryiko
2024-06-01 1:59 ` Andrii Nakryiko
2024-06-02 13:42 ` Alan Maguire
2024-05-28 12:24 ` [PATCH v5 bpf-next 9/9] kbuild,bpf: add module-specific pahole flags for distilled base BTF Alan Maguire
2024-05-31 19:06 ` Andrii Nakryiko
2024-06-02 13:41 ` Alan Maguire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13fd222ca9f31055b35c55b4ebd2b8b578b741b1.camel@gmail.com \
--to=eddyz87@gmail.com \
--cc=acme@redhat.com \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=houtao1@huawei.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=mykolal@fb.com \
--cc=nathan@kernel.org \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox