From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65ED4C4361A for ; Thu, 3 Dec 2020 20:10:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EB07207B8 for ; Thu, 3 Dec 2020 20:10:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbgLCUKr (ORCPT ); Thu, 3 Dec 2020 15:10:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:38224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725885AbgLCUKr (ORCPT ); Thu, 3 Dec 2020 15:10:47 -0500 Content-Type: text/plain; charset="utf-8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607026206; bh=/gNjhCXH8K25/+DEuKtjc5oFR3K29Q184rDH6sM64dw=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=CUL+ImMjBHqUaCoy6xzXw2ZLjExgB5yNWaO8Ob44jkDX99s/m8Ii1W4MtxhOiCon6 xxtMBFU+GQ6mcBAic+HvzSe++4ZRiCenvxj9qKa0t5PniCy7a+AYBEoRqGhajipDV0 A60mDRdA+87gs4dHMaW1zZUCt0bHztD8ZLD2u47Mg9SLFm++sdaBTK//Iqmj7hdA57 98ZLQ1N1k9931QUp3iWlqIHLpJBos9fLSXJlpSwo/TMpx/jccei811CEouNt2pjjX4 xs93QA/oXC5KIsFMBoRvfxyWQ1ZJTFmCnZd1bK+IlK2sGb+xRDjqVN57I4fXJmXB0v c33sdXEo2eSag== MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH bpf v3] libbpf: sanitise map names before pinning From: patchwork-bot+netdevbpf@kernel.org Message-Id: <160702620653.3826.6715254971435173910.git-patchwork-notify@kernel.org> Date: Thu, 03 Dec 2020 20:10:06 +0000 References: <20201203093306.107676-1-toke@redhat.com> In-Reply-To: <20201203093306.107676-1-toke@redhat.com> To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@ci.codeaurora.org Cc: daniel@iogearbox.net, ast@fb.com, andrii@kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Thu, 3 Dec 2020 10:33:06 +0100 you wrote: > When we added sanitising of map names before loading programs to libbpf, we > still allowed periods in the name. While the kernel will accept these for > the map names themselves, they are not allowed in file names when pinning > maps. This means that bpf_object__pin_maps() will fail if called on an > object that contains internal maps (such as sections .rodata). > > Fix this by replacing periods with underscores when constructing map pin > paths. This only affects the paths generated by libbpf when > bpf_object__ping_maps() is called with a path argument. Any pin paths set > by bpf_map__set_pin_path() are unaffected, and it will still be up to the > caller to avoid invalid characters in those. > > [...] Here is the summary with links: - [bpf,v3] libbpf: sanitise map names before pinning https://git.kernel.org/bpf/bpf-next/c/9cf309c56f79 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html