From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
To: bpf@vger.kernel.org,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linuxppc-dev@lists.ozlabs.org
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Brendan Jackman <jackmanb@google.com>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH 2/2] powerpc/bpf: Reject atomic ops in ppc32 JIT
Date: Fri, 02 Jul 2021 01:06:27 +0530 [thread overview]
Message-ID: <1625167931.l9jfkufqlx.naveen@linux.ibm.com> (raw)
In-Reply-To: <f05821f6-816f-c9bf-faa9-015e11f25a46@csgroup.eu>
Christophe Leroy wrote:
>
>
> Le 01/07/2021 à 17:08, Naveen N. Rao a écrit :
>> Commit 91c960b0056672 ("bpf: Rename BPF_XADD and prepare to encode other
>> atomics in .imm") converted BPF_XADD to BPF_ATOMIC and updated all JIT
>> implementations to reject JIT'ing instructions with an immediate value
>> different from BPF_ADD. However, ppc32 BPF JIT was implemented around
>> the same time and didn't include the same change. Update the ppc32 JIT
>> accordingly.
>>
>> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
>
> Shouldn't it also include a Fixes tag and stable Cc as PPC32 eBPF was added in 5.13 ?
Yes, I wasn't sure which patch to actually blame. But you're right, this
should have the below fixes tag since this affects the ppc32 eBPF JIT.
>
> Fixes: 51c66ad849a7 ("powerpc/bpf: Implement extended BPF on PPC32")
> Cc: stable@vger.kernel.org
Cc: stable@vger.kernel.org # v5.13
Thanks,
- Naveen
next prev parent reply other threads:[~2021-07-01 19:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 15:08 [PATCH 0/2] powerpc/bpf: Fix issue with atomic ops Naveen N. Rao
2021-07-01 15:08 ` [PATCH 1/2] powerpc/bpf: Fix detecting BPF atomic instructions Naveen N. Rao
2021-07-01 16:03 ` Alexei Starovoitov
2021-07-01 19:32 ` Naveen N. Rao
2021-07-01 19:33 ` Alexei Starovoitov
2021-07-02 10:26 ` Jiri Olsa
2021-07-01 15:08 ` [PATCH 2/2] powerpc/bpf: Reject atomic ops in ppc32 JIT Naveen N. Rao
2021-07-01 16:36 ` Christophe Leroy
2021-07-01 19:36 ` Naveen N. Rao [this message]
2021-07-06 10:52 ` [PATCH 0/2] powerpc/bpf: Fix issue with atomic ops Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1625167931.l9jfkufqlx.naveen@linux.ibm.com \
--to=naveen.n.rao@linux.vnet.ibm.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@iogearbox.net \
--cc=jackmanb@google.com \
--cc=jolsa@redhat.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox