[PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l

[PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l

[Vincent Li]

When run test_tc_tunnel.sh, it complains following error

ipip
encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100
test basic connectivity
nc: cannot use -p and -l

nc man page has:

     -l  Listen for an incoming connection rather than initiating
         a connection to a remote host.Cannot be used together with
         any of the options -psxz. Additionally, any timeouts specified
         with the -w option are ignored.

Correct nc in server_listen().

Signed-off-by: Vincent Li <vincent.mc.li@gmail.com>
---
 tools/testing/selftests/bpf/test_tc_tunnel.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_tc_tunnel.sh b/tools/testing/selftests/bpf/test_tc_tunnel.sh
index c9dde9b9d987..088fcad138c9 100755
--- a/tools/testing/selftests/bpf/test_tc_tunnel.sh
+++ b/tools/testing/selftests/bpf/test_tc_tunnel.sh
@@ -69,7 +69,7 @@ cleanup() {
 }
 
 server_listen() {
-	ip netns exec "${ns2}" nc "${netcat_opt}" -l -p "${port}" > "${outfile}" &
+	ip netns exec "${ns2}" nc "${netcat_opt}" -l "${port}" > "${outfile}" &
 	server_pid=$!
 	sleep 0.2
 }
-- 
2.27.0

Re: [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l

[Martin KaFai Lau]

On Mon, Jul 19, 2021 at 03:30:22PM -0700, Vincent Li wrote:
> When run test_tc_tunnel.sh, it complains following error
> 
> ipip
> encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100
> test basic connectivity
> nc: cannot use -p and -l
> 
> nc man page has:
> 
>      -l  Listen for an incoming connection rather than initiating
>          a connection to a remote host.Cannot be used together with
>          any of the options -psxz. Additionally, any timeouts specified
>          with the -w option are ignored.
> 
> Correct nc in server_listen().
I have two distros and both work with -p in listen.
However, they also work the same without -p, so it makes sense to remove it.

Acked-by: Martin KaFai Lau <kafai@fb.com>

Re: [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l

[Vincent Li]

On Tue, Jul 20, 2021 at 11:19 AM Martin KaFai Lau <kafai@fb.com> wrote:
>
> On Mon, Jul 19, 2021 at 03:30:22PM -0700, Vincent Li wrote:
> > When run test_tc_tunnel.sh, it complains following error
> >
> > ipip
> > encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100
> > test basic connectivity
> > nc: cannot use -p and -l
> >
> > nc man page has:
> >
> >      -l  Listen for an incoming connection rather than initiating
> >          a connection to a remote host.Cannot be used together with
> >          any of the options -psxz. Additionally, any timeouts specified
> >          with the -w option are ignored.
> >
> > Correct nc in server_listen().
> I have two distros and both work with -p in listen.
> However, they also work the same without -p, so it makes sense to remove it.
>

Thanks Martin, I use Centos 8 distro.

> Acked-by: Martin KaFai Lau <kafai@fb.com>

Re: [PATCH bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Mon, 19 Jul 2021 15:30:22 -0700 you wrote:
> When run test_tc_tunnel.sh, it complains following error
> 
> ipip
> encap 192.168.1.1 to 192.168.1.2, type ipip, mac none len 100
> test basic connectivity
> nc: cannot use -p and -l
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests, bpf: test_tc_tunnel.sh nc: cannot use -p and -l
    https://git.kernel.org/bpf/bpf-next/c/875fc315dbc3

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html