From: patchwork-bot+netdevbpf@kernel.org
To: Yonghong Song <yhs@fb.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, kernel-team@fb.com, delyank@fb.com
Subject: Re: [PATCH bpf-next] bpftool: fix a bug in subskeleton code generation
Date: Mon, 21 Mar 2022 21:50:10 +0000 [thread overview]
Message-ID: <164789941087.5210.5420849441093302224.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220320032009.3106133-1-yhs@fb.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Sat, 19 Mar 2022 20:20:09 -0700 you wrote:
> Compiled with clang by adding LLVM=1 both kernel and selftests/bpf
> build, I hit the following compilation error:
>
> In file included from /.../tools/testing/selftests/bpf/prog_tests/subskeleton.c:6:
> ./test_subskeleton_lib.subskel.h:168:6: error: variable 'err' is used uninitialized whenever
> 'if' condition is true [-Werror,-Wsometimes-uninitialized]
> if (!s->progs)
> ^~~~~~~~~
> ./test_subskeleton_lib.subskel.h:181:11: note: uninitialized use occurs here
> errno = -err;
> ^~~
> ./test_subskeleton_lib.subskel.h:168:2: note: remove the 'if' if its condition is always false
> if (!s->progs)
> ^~~~~~~~~~~~~~
>
> [...]
Here is the summary with links:
- [bpf-next] bpftool: fix a bug in subskeleton code generation
https://git.kernel.org/bpf/bpf-next/c/f97b8b9bd630
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-03-21 22:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-20 3:20 [PATCH bpf-next] bpftool: fix a bug in subskeleton code generation Yonghong Song
2022-03-21 14:31 ` Daniel Borkmann
2022-03-21 15:39 ` Yonghong Song
2022-03-21 21:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=164789941087.5210.5420849441093302224.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=delyank@fb.com \
--cc=kernel-team@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox