From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: ast@kernel.org, andrii@kernel.org, john.fastabend@gmail.com,
liulin063@gmail.com, bpf@vger.kernel.org
Subject: Re: [PATCH bpf 1/4] bpf: Fix incorrect verifier simulation around jmp32's jeq/jne
Date: Fri, 01 Jul 2022 20:10:15 +0000 [thread overview]
Message-ID: <165670621507.10143.15497711583157007755.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220701124727.11153-1-daniel@iogearbox.net>
Hello:
This series was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Fri, 1 Jul 2022 14:47:24 +0200 you wrote:
> Kuee reported a quirk in the jmp32's jeq/jne simulation, namely that the
> register value does not match expectations for the fall-through path. For
> example:
>
> Before fix:
>
> 0: R1=ctx(off=0,imm=0) R10=fp0
> 0: (b7) r2 = 0 ; R2_w=P0
> 1: (b7) r6 = 563 ; R6_w=P563
> 2: (87) r2 = -r2 ; R2_w=Pscalar()
> 3: (87) r2 = -r2 ; R2_w=Pscalar()
> 4: (4c) w2 |= w6 ; R2_w=Pscalar(umin=563,umax=4294967295,var_off=(0x233; 0xfffffdcc),s32_min=-2147483085) R6_w=P563
> 5: (56) if w2 != 0x8 goto pc+1 ; R2_w=P571 <--- [*]
> 6: (95) exit
> R0 !read_ok
>
> [...]
Here is the summary with links:
- [bpf,1/4] bpf: Fix incorrect verifier simulation around jmp32's jeq/jne
https://git.kernel.org/bpf/bpf/c/a12ca6277eca
- [bpf,2/4] bpf: Fix insufficient bounds propagation from adjust_scalar_min_max_vals
https://git.kernel.org/bpf/bpf/c/3844d153a41a
- [bpf,3/4] bpf, selftests: Add verifier test case for imm=0,umin=0,umax=1 scalar
https://git.kernel.org/bpf/bpf/c/73c4936f916d
- [bpf,4/4] bpf, selftests: Add verifier test case for jmp32's jeq/jne
https://git.kernel.org/bpf/bpf/c/a49b8ce7306c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-07-01 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-01 12:47 [PATCH bpf 1/4] bpf: Fix incorrect verifier simulation around jmp32's jeq/jne Daniel Borkmann
2022-07-01 12:47 ` [PATCH bpf 2/4] bpf: Fix insufficient bounds propagation from adjust_scalar_min_max_vals Daniel Borkmann
2022-07-01 12:47 ` [PATCH bpf 3/4] bpf, selftests: Add verifier test case for imm=0,umin=0,umax=1 scalar Daniel Borkmann
2022-07-01 12:47 ` [PATCH bpf 4/4] bpf, selftests: Add verifier test case for jmp32's jeq/jne Daniel Borkmann
2022-07-01 20:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165670621507.10143.15497711583157007755.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=liulin063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox