From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 528B6C43334 for ; Wed, 13 Jul 2022 00:40:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229671AbiGMAkV (ORCPT ); Tue, 12 Jul 2022 20:40:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbiGMAkS (ORCPT ); Tue, 12 Jul 2022 20:40:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E1016EEB9 for ; Tue, 12 Jul 2022 17:40:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 13CC4B81C5C for ; Wed, 13 Jul 2022 00:40:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id A00CCC341CA; Wed, 13 Jul 2022 00:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1657672814; bh=D3EcJT8vt9EEx0/SxalKPmUzuGjy0cVf/4fI/knb/Pw=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=hDJDq9zAMWltiHDSK0Lp+ww6naNZYOc3NIVC1aVL37UjMqvCCt7QlYKUs5syvc2Y3 G7qriZWb4tZjXtuxl3ftmJ04lNDSYltu4kcBoFyq7EZcLabfG3D6styFoUPX/50hFF E5jqm4xH362lMENYUB6WuMRtHRm1Gvx49mPGoAZlj8wU1fT8S8DAPAgIdTGubGyjkh 92z9FhKr/aO6QEwYEk+R2VhsBRiTP5p+B6Dq4SYlLDUIU02TSZ1jV4FfiX5/L1d2+i RSXd+wKKtxJ5UPaGE2+UlwAEfc+jU2VbzwDtNYE6M5zAG7UFGdpwqcHzWf4OgUWgRC NnmNkvwcTdBwQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 802A4E45227; Wed, 13 Jul 2022 00:40:14 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH bpf] bpf, x86: fix freeing of not-finalized bpf_prog_pack From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165767281452.22277.11387727025043528584.git-patchwork-notify@kernel.org> Date: Wed, 13 Jul 2022 00:40:14 +0000 References: <20220706002612.4013790-1-song@kernel.org> In-Reply-To: <20220706002612.4013790-1-song@kernel.org> To: Song Liu Cc: bpf@vger.kernel.org, daniel@iogearbox.net, kernel-team@fb.com, ast@kernel.org, andrii@kernel.org, syzbot+2f649ec6d2eea1495a8f@syzkaller.appspotmail.com, syzbot+87f65c75f4a72db05445@syzkaller.appspotmail.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hello: This patch was applied to bpf/bpf-next.git (master) by Alexei Starovoitov : On Tue, 5 Jul 2022 17:26:12 -0700 you wrote: > syzbot reported a few issues with bpf_prog_pack [1], [2]. These are > triggered when the program passed initial JIT in jit_subprogs(), but > failed final pass of JIT. At this point, bpf_jit_binary_pack_free() is > called before bpf_jit_binary_pack_finalize(), and the whole 2MB page is > freed. > > Fix this with a custom bpf_jit_free() for x86_64, which calls > bpf_jit_binary_pack_finalize() if necessary. Also, with custom > bpf_jit_free(), bpf_prog_aux->use_bpf_prog_pack is not needed any more, > remove it. > > [...] Here is the summary with links: - [bpf] bpf, x86: fix freeing of not-finalized bpf_prog_pack https://git.kernel.org/bpf/bpf-next/c/1d5f82d9dd47 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html