From: patchwork-bot+netdevbpf@kernel.org
To: Song Liu <song@kernel.org>
Cc: bpf@vger.kernel.org, daniel@iogearbox.net, kernel-team@fb.com,
ast@kernel.org, andrii@kernel.org
Subject: Re: [PATCH bpf-next] bpf: simplify bpf_prog_pack_[size|mask]
Date: Fri, 22 Jul 2022 20:10:14 +0000 [thread overview]
Message-ID: <165852061411.17882.11243539179338347467.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220713204950.3015201-1-song@kernel.org>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Wed, 13 Jul 2022 13:49:50 -0700 you wrote:
> Simplify the logic that selects bpf_prog_pack_size, and always use
> (PMD_SIZE * num_possible_nodes()). This is a good tradeoff, as most of the
> performance benefit observed is from less direct map fragmentation [1].
>
> Also, module_alloc(4MB) may not allocate 4MB aligned memory. Therefore, we
> cannot use (ptr & bpf_prog_pack_mask) to find the correct address of
> bpf_prog_pack. Fix this by checking the header address falls in the range
> of pack->ptr and (pack->ptr + bpf_prog_pack_size).
>
> [...]
Here is the summary with links:
- [bpf-next] bpf: simplify bpf_prog_pack_[size|mask]
https://git.kernel.org/bpf/bpf-next/c/ea2babac63d4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-07-22 20:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 20:49 [PATCH bpf-next] bpf: simplify bpf_prog_pack_[size|mask] Song Liu
2022-07-13 23:17 ` sdf
2022-07-22 20:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=165852061411.17882.11243539179338347467.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox