Re: [PATCH] selftests/bpf: declare subprog_noise as static in tailcall_bpf2bpf4

Song Liu
2022-08-26T04:44:28Z

On Thu, Aug 25, 2022 at 8:52 PM James Hilliard
<james.hilliard1@gmail.com> wrote:
>
> Due to bpf_map_lookup_elem being declared static we need to also
> declare subprog_noise as static.
>
> Fixes the following error:
> progs/tailcall_bpf2bpf4.c:26:9: error: 'bpf_map_lookup_elem' is static but used in inline function 'subprog_noise' which is not static [-Werror]
> 26 | bpf_map_lookup_elem(&nop_table, &key);
> | ^~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Acked-by: Song Liu <song@kernel.org>

> ---
> tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c
> index b67e8022d500..a017d6b2f1dd 100644
> --- a/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c
> +++ b/tools/testing/selftests/bpf/progs/tailcall_bpf2bpf4.c
> @@ -19,7 +19,7 @@ struct {
> int count = 0;
> int noise = 0;
>
> -__always_inline int subprog_noise(void)
> +static __always_inline int subprog_noise(void)
> {
> __u32 key = 0;
>
> --
> 2.34.1
>