From: patchwork-bot+netdevbpf@kernel.org
To: Yonghong Song <yhs@fb.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, kernel-team@fb.com
Subject: Re: [PATCH bpf-next v4 0/8] bpf: Support struct argument for trampoline base progs
Date: Wed, 07 Sep 2022 03:10:16 +0000 [thread overview]
Message-ID: <166252021681.29304.3215686285897138920.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20220831152641.2077476-1-yhs@fb.com>
Hello:
This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Wed, 31 Aug 2022 08:26:41 -0700 you wrote:
> Currently struct arguments are not supported for trampoline based progs.
> One of major reason is that struct argument may pass by value which may
> use more than one registers. This breaks trampoline progs where
> each argument is assumed to take one register. bcc community reported the
> issue ([1]) where struct argument is not supported for fentry program.
> typedef struct {
> uid_t val;
> } kuid_t;
> typedef struct {
> gid_t val;
> } kgid_t;
> int security_path_chown(struct path *path, kuid_t uid, kgid_t gid);
> Inside Meta, we also have a use case to attach to tcp_setsockopt()
> typedef struct {
> union {
> void *kernel;
> void __user *user;
> };
> bool is_kernel : 1;
> } sockptr_t;
> int tcp_setsockopt(struct sock *sk, int level, int optname,
> sockptr_t optval, unsigned int optlen);
>
> [...]
Here is the summary with links:
- [bpf-next,v4,1/8] bpf: Allow struct argument in trampoline based programs
https://git.kernel.org/bpf/bpf-next/c/720e6a435194
- [bpf-next,v4,2/8] bpf: x86: Support in-register struct arguments in trampoline programs
https://git.kernel.org/bpf/bpf-next/c/a9c5ad31fbdc
- [bpf-next,v4,3/8] bpf: Update descriptions for helpers bpf_get_func_arg[_cnt]()
https://git.kernel.org/bpf/bpf-next/c/27ed9353aec9
- [bpf-next,v4,4/8] bpf: arm64: No support of struct argument in trampoline programs
https://git.kernel.org/bpf/bpf-next/c/eb707dde264a
- [bpf-next,v4,5/8] libbpf: Add new BPF_PROG2 macro
https://git.kernel.org/bpf/bpf-next/c/34586d29f8df
- [bpf-next,v4,6/8] selftests/bpf: Add struct argument tests with fentry/fexit programs.
https://git.kernel.org/bpf/bpf-next/c/1642a3945e22
- [bpf-next,v4,7/8] selftests/bpf: Use BPF_PROG2 for some fentry programs without struct arguments
https://git.kernel.org/bpf/bpf-next/c/a7c2ca3a2f69
- [bpf-next,v4,8/8] selftests/bpf: Add tracing_struct test in DENYLIST.s390x
https://git.kernel.org/bpf/bpf-next/c/ae63c10fc241
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-09-07 3:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 15:26 [PATCH bpf-next v4 0/8] bpf: Support struct argument for trampoline base progs Yonghong Song
2022-08-31 15:26 ` [PATCH bpf-next v4 1/8] bpf: Allow struct argument in trampoline based programs Yonghong Song
2022-08-31 15:26 ` [PATCH bpf-next v4 2/8] bpf: x86: Support in-register struct arguments in trampoline programs Yonghong Song
2022-09-06 16:40 ` Kui-Feng Lee
2022-09-06 19:30 ` Yonghong Song
2022-09-07 3:00 ` Alexei Starovoitov
2022-09-07 18:04 ` Yonghong Song
2022-08-31 15:26 ` [PATCH bpf-next v4 3/8] bpf: Update descriptions for helpers bpf_get_func_arg[_cnt]() Yonghong Song
2022-09-02 7:56 ` Jiri Olsa
2022-09-06 16:12 ` Yonghong Song
2022-08-31 15:27 ` [PATCH bpf-next v4 4/8] bpf: arm64: No support of struct argument in trampoline programs Yonghong Song
2022-08-31 15:27 ` [PATCH bpf-next v4 5/8] libbpf: Add new BPF_PROG2 macro Yonghong Song
2022-09-09 0:11 ` Andrii Nakryiko
2022-09-09 16:31 ` Yonghong Song
2022-09-09 18:07 ` Andrii Nakryiko
2022-08-31 15:27 ` [PATCH bpf-next v4 6/8] selftests/bpf: Add struct argument tests with fentry/fexit programs Yonghong Song
2022-08-31 15:27 ` [PATCH bpf-next v4 7/8] selftests/bpf: Use BPF_PROG2 for some fentry programs without struct arguments Yonghong Song
2022-08-31 15:27 ` [PATCH bpf-next v4 8/8] selftests/bpf: Add tracing_struct test in DENYLIST.s390x Yonghong Song
2022-09-07 3:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166252021681.29304.3215686285897138920.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox