From: patchwork-bot+netdevbpf@kernel.org
To: Gerhard Engleder <gerhard@engleder-embedded.com>
Cc: ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net,
kuba@kernel.org, hawk@kernel.org, john.fastabend@gmail.com,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] samples/bpf: Fix map interation in xdp1_user
Date: Wed, 19 Oct 2022 18:00:21 +0000 [thread overview]
Message-ID: <166620242101.8250.6135773803189204405.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221013200922.17167-1-gerhard@engleder-embedded.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Thu, 13 Oct 2022 22:09:22 +0200 you wrote:
> BPF map iteration in xdp1_user results in endless loop without any
> output, because the return value of bpf_map_get_next_key() is checked
> against the wrong value.
>
> Other call locations of bpf_map_get_next_key() check for equal 0 for
> continuing the iteration. xdp1_user checks against unequal -1. This is
> wrong for a function which can return arbitrary negative errno values,
> because a return value of e.g. -2 results in an endless loop.
>
> [...]
Here is the summary with links:
- [net-next] samples/bpf: Fix map interation in xdp1_user
https://git.kernel.org/bpf/bpf-next/c/05ee658c654b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-10-19 18:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 20:09 [PATCH net-next] samples/bpf: Fix map interation in xdp1_user Gerhard Engleder
2022-10-17 16:27 ` Song Liu
2022-10-19 18:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166620242101.8250.6135773803189204405.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=gerhard@engleder-embedded.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox