From: patchwork-bot+netdevbpf@kernel.org
To: Delyan Kratunov <delyank@meta.com>
Cc: daniel@iogearbox.net, songliubraving@meta.com, ast@kernel.org,
andrii@kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v3] selftests/bpf: fix task_local_storage/exit_creds rcu usage
Date: Fri, 21 Oct 2022 21:10:16 +0000 [thread overview]
Message-ID: <166638661643.2639.16814405561858562162.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <156d4ef82275a074e8da8f4cffbd01b0c1466493.camel@meta.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Fri, 21 Oct 2022 19:36:38 +0000 you wrote:
> BPF CI has revealed flakiness in the task_local_storage/exit_creds test.
> The failure point in CI [1] is that null_ptr_count is equal to 0,
> which indicates that the program hasn't run yet. This points to the
> kern_sync_rcu (sys_membarrier -> synchronize_rcu underneath) not
> waiting sufficiently.
>
> Indeed, synchronize_rcu only waits for read-side sections that started
> before the call. If the program execution starts *during* the
> synchronize_rcu invocation (due to, say, preemption), the test won't
> wait long enough.
>
> [...]
Here is the summary with links:
- [bpf-next,v3] selftests/bpf: fix task_local_storage/exit_creds rcu usage
https://git.kernel.org/bpf/bpf-next/c/eb814cf1adea
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-10-21 21:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 19:36 [PATCH bpf-next v3] selftests/bpf: fix task_local_storage/exit_creds rcu usage Delyan Kratunov
2022-10-21 21:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166638661643.2639.16814405561858562162.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=delyank@meta.com \
--cc=songliubraving@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox