BPF List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Stanislav Fomichev <sdf@google.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	andrii@kernel.org, martin.lau@linux.dev, song@kernel.org,
	yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
	haoluo@google.com, jolsa@kernel.org, edumazet@google.com,
	syzbot+f635e86ec3fa0a37e019@syzkaller.appspotmail.com
Subject: Re: [PATCH bpf-next] bpf: make sure skb->len != 0 when redirecting to a tunneling device
Date: Thu, 03 Nov 2022 20:50:16 +0000	[thread overview]
Message-ID: <166750861623.15406.9834935004945257134.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221027225537.353077-1-sdf@google.com>

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Thu, 27 Oct 2022 15:55:37 -0700 you wrote:
> syzkaller managed to trigger another case where skb->len == 0
> when we enter __dev_queue_xmit:
> 
> WARNING: CPU: 0 PID: 2470 at include/linux/skbuff.h:2576 skb_assert_len include/linux/skbuff.h:2576 [inline]
> WARNING: CPU: 0 PID: 2470 at include/linux/skbuff.h:2576 __dev_queue_xmit+0x2069/0x35e0 net/core/dev.c:4295
> 
> Call Trace:
>  dev_queue_xmit+0x17/0x20 net/core/dev.c:4406
>  __bpf_tx_skb net/core/filter.c:2115 [inline]
>  __bpf_redirect_no_mac net/core/filter.c:2140 [inline]
>  __bpf_redirect+0x5fb/0xda0 net/core/filter.c:2163
>  ____bpf_clone_redirect net/core/filter.c:2447 [inline]
>  bpf_clone_redirect+0x247/0x390 net/core/filter.c:2419
>  bpf_prog_48159a89cb4a9a16+0x59/0x5e
>  bpf_dispatcher_nop_func include/linux/bpf.h:897 [inline]
>  __bpf_prog_run include/linux/filter.h:596 [inline]
>  bpf_prog_run include/linux/filter.h:603 [inline]
>  bpf_test_run+0x46c/0x890 net/bpf/test_run.c:402
>  bpf_prog_test_run_skb+0xbdc/0x14c0 net/bpf/test_run.c:1170
>  bpf_prog_test_run+0x345/0x3c0 kernel/bpf/syscall.c:3648
>  __sys_bpf+0x43a/0x6c0 kernel/bpf/syscall.c:5005
>  __do_sys_bpf kernel/bpf/syscall.c:5091 [inline]
>  __se_sys_bpf kernel/bpf/syscall.c:5089 [inline]
>  __x64_sys_bpf+0x7c/0x90 kernel/bpf/syscall.c:5089
>  do_syscall_64+0x54/0x70 arch/x86/entry/common.c:48
>  entry_SYSCALL_64_after_hwframe+0x61/0xc6
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpf: make sure skb->len != 0 when redirecting to a tunneling device
    https://git.kernel.org/bpf/bpf-next/c/0ed041b1dd33

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2022-11-03 20:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-27 22:55 [PATCH bpf-next] bpf: make sure skb->len != 0 when redirecting to a tunneling device Stanislav Fomichev
2022-11-01 20:28 ` Martin KaFai Lau
2022-11-01 23:39   ` Stanislav Fomichev
2022-11-02  0:43     ` Martin KaFai Lau
2022-11-03 21:32       ` Martin KaFai Lau
2022-11-03 21:38         ` Stanislav Fomichev
2022-11-03 22:20           ` Martin KaFai Lau
2022-11-03 20:50 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=166750861623.15406.9834935004945257134.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=edumazet@google.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=syzbot+f635e86ec3fa0a37e019@syzkaller.appspotmail.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox