From: patchwork-bot+netdevbpf@kernel.org
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
kernel-team@fb.com
Subject: Re: [PATCH bpf-next 1/2] libbpf: avoid enum forward-declarations in public API in C++ mode
Date: Wed, 30 Nov 2022 22:00:17 +0000 [thread overview]
Message-ID: <166984561784.15567.17028344819753502325.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221130200013.2997831-1-andrii@kernel.org>
Hello:
This series was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Wed, 30 Nov 2022 12:00:12 -0800 you wrote:
> C++ enum forward declarations are fundamentally not compatible with pure
> C enum definitions, and so libbpf's use of `enum bpf_stats_type;`
> forward declaration in libbpf/bpf.h public API header is causing C++
> compilation issues.
>
> More details can be found in [0], but it comes down to C++ supporting
> enum forward declaration only with explicitly specified backing type:
>
> [...]
Here is the summary with links:
- [bpf-next,1/2] libbpf: avoid enum forward-declarations in public API in C++ mode
https://git.kernel.org/bpf/bpf-next/c/b42693415b86
- [bpf-next,2/2] selftests/bpf: make sure enum-less bpf_enable_stats() API works in C++ mode
https://git.kernel.org/bpf/bpf-next/c/f8186bf65ae6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-11-30 22:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 20:00 [PATCH bpf-next 1/2] libbpf: avoid enum forward-declarations in public API in C++ mode Andrii Nakryiko
2022-11-30 20:00 ` [PATCH bpf-next 2/2] selftests/bpf: make sure enum-less bpf_enable_stats() API works " Andrii Nakryiko
2022-11-30 22:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=166984561784.15567.17028344819753502325.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox