From: patchwork-bot+netdevbpf@kernel.org
To: Khem Raj <raj.khem@gmail.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
song@kernel.org, yhs@fb.com, jolsa@kernel.org,
paul.walmsley@sifive.com, palmer@dabbelt.com, nathan@kernel.org,
ndesaulniers@google.com, andrii.nakryiko@gmail.com
Subject: Re: [PATCH v2] libbpf: Fix build warning on ref_ctr_off
Date: Wed, 21 Dec 2022 00:00:16 +0000 [thread overview]
Message-ID: <167158081662.32440.15055359412437154748.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20221219191526.296264-1-raj.khem@gmail.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Mon, 19 Dec 2022 11:15:26 -0800 you wrote:
> Clang warns on 32-bit ARM on this comparision
>
> libbpf.c:10497:18: error: result of comparison of constant 4294967296 with expression of type 'size_t' (aka 'unsigned int') is always false [-Werror,-Wtautological-constant-out-of-range-compare]
> if (ref_ctr_off >= (1ULL << PERF_UPROBE_REF_CTR_OFFSET_BITS))
> ~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> typecast ref_ctr_off to __u64 in the check conditional, it is false on 32bit anyways.
>
> [...]
Here is the summary with links:
- [v2] libbpf: Fix build warning on ref_ctr_off
https://git.kernel.org/bpf/bpf-next/c/1520e8466d68
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2022-12-21 0:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 19:15 [PATCH v2] libbpf: Fix build warning on ref_ctr_off Khem Raj
2022-12-21 0:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167158081662.32440.15055359412437154748.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jolsa@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=raj.khem@gmail.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox