public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Magnus Karlsson <magnus.karlsson@gmail.com>
Cc: magnus.karlsson@intel.com, bjorn@kernel.org, ast@kernel.org,
	daniel@iogearbox.net, netdev@vger.kernel.org,
	jonathan.lemon@gmail.com, maciej.fijalkowski@intel.com,
	kuba@kernel.org, toke@redhat.com, pabeni@redhat.com,
	davem@davemloft.net, aelior@marvell.com, manishc@marvell.com,
	horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com,
	mst@redhat.com, jasowang@redhat.com, ioana.ciornei@nxp.com,
	madalin.bucur@nxp.com, bpf@vger.kernel.org
Subject: Re: [PATCH net v2 0/5] net: xdp: execute xdp_do_flush() before napi_complete_done()
Date: Sat, 28 Jan 2023 06:40:19 +0000	[thread overview]
Message-ID: <167488801911.1883.7455001304854457036.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230125074901.2737-1-magnus.karlsson@gmail.com>

Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed, 25 Jan 2023 08:48:56 +0100 you wrote:
> Make sure that xdp_do_flush() is always executed before
> napi_complete_done(). This is important for two reasons. First, a
> redirect to an XSKMAP assumes that a call to xdp_do_redirect() from
> napi context X on CPU Y will be followed by a xdp_do_flush() from the
> same napi context and CPU. This is not guaranteed if the
> napi_complete_done() is executed before xdp_do_flush(), as it tells
> the napi logic that it is fine to schedule napi context X on another
> CPU. Details from a production system triggering this bug using the
> veth driver can be found in [1].
> 
> [...]

Here is the summary with links:
  - [net,v2,1/5] qede: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/2ccce20d51fa
  - [net,v2,2/5] lan966x: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/12b5717990c8
  - [net,v2,3/5] virtio-net: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/ad7e615f646c
  - [net,v2,4/5] dpaa_eth: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/b534013798b7
  - [net,v2,5/5] dpaa2-eth: execute xdp_do_flush() before napi_complete_done()
    https://git.kernel.org/netdev/net/c/a3191c4d86c5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2023-01-28  6:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-25  7:48 [PATCH net v2 0/5] net: xdp: execute xdp_do_flush() before napi_complete_done() Magnus Karlsson
2023-01-25  7:48 ` [PATCH net v2 1/5] qede: " Magnus Karlsson
2023-01-25  7:48 ` [PATCH net v2 2/5] lan966x: " Magnus Karlsson
2023-01-25  7:48 ` [PATCH net v2 3/5] virtio-net: " Magnus Karlsson
2023-01-27 10:49   ` Michael S. Tsirkin
2023-01-25  7:49 ` [PATCH net v2 4/5] dpaa_eth: " Magnus Karlsson
2023-01-25 14:58   ` Camelia Alexandra Groza
2023-01-25  7:49 ` [PATCH net v2 5/5] dpaa2-eth: " Magnus Karlsson
2023-01-27 10:50 ` [PATCH net v2 0/5] net: xdp: " Michael S. Tsirkin
2023-01-28  6:40 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=167488801911.1883.7455001304854457036.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=aelior@marvell.com \
    --cc=ast@kernel.org \
    --cc=bjorn@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=horatiu.vultur@microchip.com \
    --cc=ioana.ciornei@nxp.com \
    --cc=jasowang@redhat.com \
    --cc=jonathan.lemon@gmail.com \
    --cc=kuba@kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=madalin.bucur@nxp.com \
    --cc=magnus.karlsson@gmail.com \
    --cc=magnus.karlsson@intel.com \
    --cc=manishc@marvell.com \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=toke@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox