public inbox for bpf@vger.kernel.org
 help / color / mirror / Atom feed
From: Alan Maguire <alan.maguire@oracle.com>
To: acme@kernel.org, olsajiri@gmail.com, ast@kernel.org
Cc: daniel@iogearbox.net, andrii@kernel.org, yhs@fb.com,
	eddyz87@gmail.com, sinquersw@gmail.com, timo@incline.eu,
	songliubraving@fb.com, john.fastabend@gmail.com,
	kpsingh@chromium.org, sdf@google.com, haoluo@google.com,
	martin.lau@kernel.org, bpf@vger.kernel.org,
	Alan Maguire <alan.maguire@oracle.com>
Subject: [RFC dwarves 3/4] pahole: update descriptions for btf_gen_optimized, skip_encoding_btf_inconsistent_proto
Date: Fri, 17 Feb 2023 23:10:32 +0000	[thread overview]
Message-ID: <1676675433-10583-4-git-send-email-alan.maguire@oracle.com> (raw)
In-Reply-To: <1676675433-10583-1-git-send-email-alan.maguire@oracle.com>

Semantics are changed such that we do not skip for optimized-out parameters,
rather unexpected register use.

Signed-off-by: Alan Maguire <alan.maguire@oracle.com>
---
 pahole.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pahole.c b/pahole.c
index 53dfb07..6fc4ed6 100644
--- a/pahole.c
+++ b/pahole.c
@@ -1647,12 +1647,12 @@ static const struct argp_option pahole__options[] = {
 	{
 		.name = "btf_gen_optimized",
 		.key  = ARGP_btf_gen_optimized,
-		.doc  = "Generate BTF for functions with optimization-related suffixes (.isra, .constprop).  BTF will only be generated if a function does not optimize out parameters."
+		.doc  = "Generate BTF for functions with optimization-related suffixes (.isra, .constprop)."
 	},
 	{
 		.name = "skip_encoding_btf_inconsistent_proto",
 		.key = ARGP_skip_encoding_btf_inconsistent_proto,
-		.doc = "Skip functions that have multiple inconsistent function prototypes sharing the same name, or have optimized-out parameters."
+		.doc = "Skip functions that have multiple inconsistent function prototypes sharing the same name, or that use unexpected registers for parameter values."
 	},
 	{
 		.name = NULL,
-- 
2.31.1


  parent reply	other threads:[~2023-02-18  1:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 23:10 [RFC dwarves 0/4] dwarves: change BTF encoding skip logic for functions Alan Maguire
2023-02-17 23:10 ` [RFC dwarves 1/4] dwarf_loader: mark functions that do not use expected registers for params Alan Maguire
2023-02-20 19:03   ` Alexei Starovoitov
2023-02-20 19:42     ` Alan Maguire
2023-02-20 22:30       ` Alexei Starovoitov
2023-02-21 15:52         ` Alan Maguire
2023-02-17 23:10 ` [RFC dwarves 2/4] btf_encoder: exclude functions with unexpected param register use not optimizations Alan Maguire
2023-02-17 23:10 ` Alan Maguire [this message]
2023-02-17 23:10 ` [RFC dwarves 4/4] pahole: update man page for options also Alan Maguire
2023-02-18 14:12 ` [RFC dwarves 0/4] dwarves: change BTF encoding skip logic for functions Arnaldo Carvalho de Melo
2023-02-18 14:37   ` Arnaldo Carvalho de Melo
2023-02-19 22:23 ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1676675433-10583-4-git-send-email-alan.maguire@oracle.com \
    --to=alan.maguire@oracle.com \
    --cc=acme@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=kpsingh@chromium.org \
    --cc=martin.lau@kernel.org \
    --cc=olsajiri@gmail.com \
    --cc=sdf@google.com \
    --cc=sinquersw@gmail.com \
    --cc=songliubraving@fb.com \
    --cc=timo@incline.eu \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox