From: patchwork-bot+netdevbpf@kernel.org
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
kernel-team@meta.com
Subject: Re: [PATCH bpf-next] bpf: ensure state checkpointing at iter_next() call sites
Date: Fri, 10 Mar 2023 16:40:18 +0000 [thread overview]
Message-ID: <167846641897.10287.2969904343162506781.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230310060149.625887-1-andrii@kernel.org>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Thu, 9 Mar 2023 22:01:49 -0800 you wrote:
> State equivalence check and checkpointing performed in is_state_visited()
> employs certain heuristics to try to save memory by avoiding state checkpoints
> if not enough jumps and instructions happened since last checkpoint. This leads
> to unpredictability of whether a particular instruction will be checkpointed
> and how regularly. While normally this is not causing much problems (except
> inconveniences for predictable verifier tests, which we overcome with
> BPF_F_TEST_STATE_FREQ flag), turns out it's not the case for open-coded
> iterators.
>
> [...]
Here is the summary with links:
- [bpf-next] bpf: ensure state checkpointing at iter_next() call sites
https://git.kernel.org/bpf/bpf-next/c/4b5ce570dbef
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-03-10 16:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 6:01 [PATCH bpf-next] bpf: ensure state checkpointing at iter_next() call sites Andrii Nakryiko
2023-03-10 16:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167846641897.10287.2969904343162506781.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox