From: patchwork-bot+netdevbpf@kernel.org
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
kernel-team@meta.com
Subject: Re: [PATCH bpf] bpf: take into account liveness when propagating precision
Date: Fri, 10 Mar 2023 18:20:19 +0000 [thread overview]
Message-ID: <167847241942.709.16256872568533003476.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230309224131.57449-1-andrii@kernel.org>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Thu, 9 Mar 2023 14:41:31 -0800 you wrote:
> When doing state comparison, if old state has register that is not
> marked as REG_LIVE_READ, then we just skip comparison, regardless what's
> the state of corresponing register in current state. This is because not
> REG_LIVE_READ register is irrelevant for further program execution and
> correctness. All good here.
>
> But when we get to precision propagation, after two states were declared
> equivalent, we don't take into account old register's liveness, and thus
> attempt to propagate precision for register in current state even if
> that register in old state was not REG_LIVE_READ anymore. This is bad,
> because register in current state could be anything at all and this
> could cause -EFAULT due to internal logic bugs.
>
> [...]
Here is the summary with links:
- [bpf] bpf: take into account liveness when propagating precision
https://git.kernel.org/bpf/bpf-next/c/52c2b005a3c1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-03-10 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-09 22:41 [PATCH bpf] bpf: take into account liveness when propagating precision Andrii Nakryiko
2023-03-10 18:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167847241942.709.16256872568533003476.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox