From: patchwork-bot+netdevbpf@kernel.org
To: Dave Marchevsky <davemarchevsky@fb.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
andrii@kernel.org, martin.lau@kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v1 bpf-next] bpf: Disable migration when freeing stashed local kptr using obj drop
Date: Tue, 14 Mar 2023 00:00:16 +0000 [thread overview]
Message-ID: <167875201690.9292.11466523661883628604.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230313214641.3731908-1-davemarchevsky@fb.com>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Mon, 13 Mar 2023 14:46:41 -0700 you wrote:
> When a local kptr is stashed in a map and freed when the map goes away,
> currently an error like the below appears:
>
> [ 39.195695] BUG: using smp_processor_id() in preemptible [00000000] code: kworker/u32:15/2875
> [ 39.196549] caller is bpf_mem_free+0x56/0xc0
> [ 39.196958] CPU: 15 PID: 2875 Comm: kworker/u32:15 Tainted: G O 6.2.0-13016-g22df776a9a86 #4477
> [ 39.197897] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.12.0-59-gc9ba5276e321-prebuilt.qemu.org 04/01/2014
> [ 39.198949] Workqueue: events_unbound bpf_map_free_deferred
> [ 39.199470] Call Trace:
> [ 39.199703] <TASK>
> [ 39.199911] dump_stack_lvl+0x60/0x70
> [ 39.200267] check_preemption_disabled+0xbf/0xe0
> [ 39.200704] bpf_mem_free+0x56/0xc0
> [ 39.201032] ? bpf_obj_new_impl+0xa0/0xa0
> [ 39.201430] bpf_obj_free_fields+0x1cd/0x200
> [ 39.201838] array_map_free+0xad/0x220
> [ 39.202193] ? finish_task_switch+0xe5/0x3c0
> [ 39.202614] bpf_map_free_deferred+0xea/0x210
> [ 39.203006] ? lockdep_hardirqs_on_prepare+0xe/0x220
> [ 39.203460] process_one_work+0x64f/0xbe0
> [ 39.203822] ? pwq_dec_nr_in_flight+0x110/0x110
> [ 39.204264] ? do_raw_spin_lock+0x107/0x1c0
> [ 39.204662] ? lockdep_hardirqs_on_prepare+0xe/0x220
> [ 39.205107] worker_thread+0x74/0x7a0
> [ 39.205451] ? process_one_work+0xbe0/0xbe0
> [ 39.205818] kthread+0x171/0x1a0
> [ 39.206111] ? kthread_complete_and_exit+0x20/0x20
> [ 39.206552] ret_from_fork+0x1f/0x30
> [ 39.206886] </TASK>
>
> [...]
Here is the summary with links:
- [v1,bpf-next] bpf: Disable migration when freeing stashed local kptr using obj drop
https://git.kernel.org/bpf/bpf-next/c/9e36a204bd43
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2023-03-14 0:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 21:46 [PATCH v1 bpf-next] bpf: Disable migration when freeing stashed local kptr using obj drop Dave Marchevsky
2023-03-14 0:00 ` patchwork-bot+netdevbpf [this message]
2023-03-14 5:35 ` John Fastabend
2023-03-15 0:07 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167875201690.9292.11466523661883628604.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox