From: patchwork-bot+netdevbpf@kernel.org
To: Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
martin.lau@kernel.org, kernel-team@meta.com, error27@gmail.com
Subject: Re: [PATCH bpf-next] bpf: remember meta->iter info only for initialized iters
Date: Thu, 23 Mar 2023 00:40:18 +0000 [thread overview]
Message-ID: <167953201882.8757.12072310215576608930.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230322232502.836171-1-andrii@kernel.org>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:
On Wed, 22 Mar 2023 16:25:02 -0700 you wrote:
> For iter_new() functions iterator state's slot might not be yet
> initialized, in which case iter_get_spi() will return -ERANGE. This is
> expected and is handled properly. But for iter_next() and iter_destroy()
> cases iter slot is supposed to be initialized and correct, so -ERANGE is
> not possible.
>
> Move meta->iter.{spi,frameno} initialization into iter_next/iter_destroy
> handling branch to make it more explicit that valid information will be
> remembered in meta->iter block for subsequent use in process_iter_next_call(),
> avoiding confusingly looking -ERANGE assignment for meta->iter.spi.
>
> [...]
Here is the summary with links:
- [bpf-next] bpf: remember meta->iter info only for initialized iters
https://git.kernel.org/bpf/bpf-next/c/b63cbc490e18
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-03-23 0:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 23:25 [PATCH bpf-next] bpf: remember meta->iter info only for initialized iters Andrii Nakryiko
2023-03-23 0:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167953201882.8757.12072310215576608930.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=error27@gmail.com \
--cc=kernel-team@meta.com \
--cc=martin.lau@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox