From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0058CC77B61 for ; Tue, 25 Apr 2023 02:10:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233255AbjDYCKW (ORCPT ); Mon, 24 Apr 2023 22:10:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232950AbjDYCKW (ORCPT ); Mon, 24 Apr 2023 22:10:22 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8B2D5FFD; Mon, 24 Apr 2023 19:10:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 79D93628D3; Tue, 25 Apr 2023 02:10:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id D1827C433EF; Tue, 25 Apr 2023 02:10:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1682388618; bh=LV7mzaIjcHN7+qepxhchqcdjdPN3jQAWFFhyBHFUy8U=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=q94SqZe4H8IsLWkzsRmsEoGvMsPjq1yZW+N8eEysVZ79LWhW4oGTrololrpxGyKwj bW0hMK6QEQ/sC6RTat+Xn09GDgD5m7SU0KMFWPybOO/P2dRCGH9OFJwIzp0yIFKtSr sxN78N5bGaIrTADFbFoINtUNO1N0YFrFMMDm3X0g2TEHs/UBfnJsTVPkFs4PNV5Cc2 pPzJTTGTf8PwC9ZSgxxKb+uZ5KC6YvP9hhXyrVjJocZ+/LMhJqaeztKGmbZzc3EhAm VEXW13oTpD1S6xd+O8Ubpjfe5SHB/wEqGl/KNk3OW2PxPCPzIdO0KK4iLQ46s888aV ok3VxYIZyqW3Q== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id AC6E7E5FFC7; Tue, 25 Apr 2023 02:10:18 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next v3] lan966x: Don't use xdp_frame when action is XDP_TX From: patchwork-bot+netdevbpf@kernel.org Message-Id: <168238861870.3463.8505415279039848704.git-patchwork-notify@kernel.org> Date: Tue, 25 Apr 2023 02:10:18 +0000 References: <20230422142344.3630602-1-horatiu.vultur@microchip.com> In-Reply-To: <20230422142344.3630602-1-horatiu.vultur@microchip.com> To: Horatiu Vultur Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, ast@kernel.org, daniel@iogearbox.net, hawk@kernel.org, john.fastabend@gmail.com, aleksander.lobakin@intel.com, maciej.fijalkowski@intel.com, UNGLinuxDriver@microchip.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sat, 22 Apr 2023 16:23:44 +0200 you wrote: > When the action of an xdp program was XDP_TX, lan966x was creating > a xdp_frame and use this one to send the frame back. But it is also > possible to send back the frame without needing a xdp_frame, because > it is possible to send it back using the page. > And then once the frame is transmitted is possible to use directly > page_pool_recycle_direct as lan966x is using page pools. > This would save some CPU usage on this path, which results in higher > number of transmitted frames. Bellow are the statistics: > Frame size: Improvement: > 64 ~8% > 256 ~11% > 512 ~8% > 1000 ~0% > 1500 ~0% > > [...] Here is the summary with links: - [net-next,v3] lan966x: Don't use xdp_frame when action is XDP_TX https://git.kernel.org/netdev/net-next/c/700f11eb2cbe You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html