From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@ci.codeaurora.org
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, mauricio.vasquez@polito.it,
hsinweih@uci.edu, bpf@vger.kernel.org
Subject: Re: [PATCH bpf] bpf: Avoid deadlock when using queue and stack maps from NMI
Date: Tue, 12 Sep 2023 02:10:29 +0000 [thread overview]
Message-ID: <169448462907.6410.11732142190873200040.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230911132815.717240-1-toke@redhat.com>
Hello:
This patch was applied to bpf/bpf.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Mon, 11 Sep 2023 15:28:14 +0200 you wrote:
> Sysbot discovered that the queue and stack maps can deadlock if they are
> being used from a BPF program that can be called from NMI context (such as
> one that is attached to a perf HW counter event). To fix this, add an
> in_nmi() check and use raw_spin_trylock() in NMI context, erroring out if
> grabbing the lock fails.
>
> Fixes: f1a2e44a3aec ("bpf: add queue and stack maps")
> Reported-by: Hsin-Wei Hung <hsinweih@uci.edu>
> Tested-by: Hsin-Wei Hung <hsinweih@uci.edu>
> Co-developed-by: Hsin-Wei Hung <hsinweih@uci.edu>
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
>
> [...]
Here is the summary with links:
- [bpf] bpf: Avoid deadlock when using queue and stack maps from NMI
https://git.kernel.org/bpf/bpf/c/a34a9f1a19af
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-09-12 2:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-11 13:28 [PATCH bpf] bpf: Avoid deadlock when using queue and stack maps from NMI Toke Høiland-Jørgensen
2023-09-12 2:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169448462907.6410.11732142190873200040.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@ci.codeaurora.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=hsinweih@uci.edu \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=mauricio.vasquez@polito.it \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox