From: patchwork-bot+netdevbpf@kernel.org
To: Yonghong Song <yonghong.song@linux.dev>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, kernel-team@fb.com, martin.lau@kernel.org
Subject: Re: [PATCH bpf v3] bpf: Fix a verifier bug due to incorrect branch offset comparison with cpu=v4
Date: Sat, 02 Dec 2023 00:00:24 +0000 [thread overview]
Message-ID: <170147522453.5829.11152285037778177975.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20231201024640.3417057-1-yonghong.song@linux.dev>
Hello:
This patch was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Thu, 30 Nov 2023 18:46:40 -0800 you wrote:
> Bpf cpu=v4 support is introduced in [1] and Commit 4cd58e9af8b9
> ("bpf: Support new 32bit offset jmp instruction") added support for new
> 32bit offset jmp instruction. Unfortunately, in function
> bpf_adj_delta_to_off(), for new branch insn with 32bit offset, the offset
> (plus/minor a small delta) compares to 16-bit offset bound
> [S16_MIN, S16_MAX], which caused the following verification failure:
> $ ./test_progs-cpuv4 -t verif_scale_pyperf180
> ...
> insn 10 cannot be patched due to 16-bit range
> ...
> libbpf: failed to load object 'pyperf180.bpf.o'
> scale_test:FAIL:expect_success unexpected error: -12 (errno 12)
> #405 verif_scale_pyperf180:FAIL
>
> [...]
Here is the summary with links:
- [bpf,v3] bpf: Fix a verifier bug due to incorrect branch offset comparison with cpu=v4
https://git.kernel.org/bpf/bpf/c/dfce9cb31405
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-12-02 0:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 2:46 [PATCH bpf v3] bpf: Fix a verifier bug due to incorrect branch offset comparison with cpu=v4 Yonghong Song
2023-12-01 23:53 ` Andrii Nakryiko
2023-12-02 0:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170147522453.5829.11152285037778177975.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox