From: patchwork-bot+netdevbpf@kernel.org
To: Quentin Monnet <qmo@kernel.org>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, eddyz87@gmail.com, song@kernel.org,
yonghong.song@linux.dev, john.fastabend@gmail.com,
kpsingh@kernel.org, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next] bpftool: Enable libbpf logs when loading pid_iter in debug mode
Date: Wed, 20 Mar 2024 06:20:29 +0000 [thread overview]
Message-ID: <171091562924.21070.16045518099386859584.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240320012241.42991-1-qmo@kernel.org>
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Wed, 20 Mar 2024 01:22:41 +0000 you wrote:
> When trying to load the pid_iter BPF program used to iterate over the
> PIDs of the processes holding file descriptors to BPF links, we would
> unconditionally silence libbpf in order to keep the output clean if the
> kernel does not support iterators and loading fails.
>
> Although this is the desirable behaviour in most cases, this may hide
> bugs in the pid_iter program that prevent it from loading, and it makes
> it hard to debug such load failures, even in "debug" mode. Instead, it
> makes more sense to print libbpf's logs when we pass the -d|--debug flag
> to bpftool, so that users get the logs to investigate failures without
> having to edit bpftool's source code.
>
> [...]
Here is the summary with links:
- [bpf-next] bpftool: Enable libbpf logs when loading pid_iter in debug mode
https://git.kernel.org/bpf/bpf-next/c/be24a895149b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-03-20 6:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-20 1:22 [PATCH bpf-next] bpftool: Enable libbpf logs when loading pid_iter in debug mode Quentin Monnet
2024-03-20 6:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171091562924.21070.16045518099386859584.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=qmo@kernel.org \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox