BPF List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Anton Protopopov <aspsk@isovalent.com>
Cc: ast@kernel.org, andrii@kernel.org, daniel@iogearbox.net,
	jolsa@kernel.org, martin.lau@linux.dev, sdf@google.com,
	bpf@vger.kernel.org
Subject: Re: [PATCH bpf] bpf: fix a verifier verbose message
Date: Fri, 12 Apr 2024 16:40:28 +0000	[thread overview]
Message-ID: <171294002860.22562.13255273895033166786.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240412141100.3562942-1-aspsk@isovalent.com>

Hello:

This patch was applied to bpf/bpf.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Fri, 12 Apr 2024 16:11:00 +0200 you wrote:
> Long ago a map file descriptor in a pseudo ldimm64 instruction could
> only be present as an immediate value insn[0].imm, and thus this value
> was used in a verbose verifier message printed when the file descriptor
> wasn't valid. Since addition of BPF_PSEUDO_MAP_IDX_VALUE/BPF_PSEUDO_MAP_IDX
> the insn[0].imm field can also contain an index pointing to the file
> descriptor in the attr.fd_array array.  However, if the file descriptor
> is invalid, the verifier still prints the verbose message containing
> value of insn[0].imm. Patch the verifier message to always print the
> actual file descriptor value.
> 
> [...]

Here is the summary with links:
  - [bpf] bpf: fix a verifier verbose message
    https://git.kernel.org/bpf/bpf/c/37eacb9f6e89

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2024-04-12 16:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 14:11 [PATCH bpf] bpf: fix a verifier verbose message Anton Protopopov
2024-04-12 16:40 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171294002860.22562.13255273895033166786.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=aspsk@isovalent.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jolsa@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox