BPF List
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net,
	john.fastabend@gmail.com, hdanton@sina.com,
	penguin-kernel@i-love.sakura.ne.jp, kernel-team@cloudflare.com,
	syzbot+ec941d6e24f633a59172@syzkaller.appspotmail.com
Subject: Re: [PATCH bpf 0/3] Block deletes from sockmap for tracing programs
Date: Mon, 27 May 2024 17:40:29 +0000	[thread overview]
Message-ID: <171683162928.10914.15797940779296702902.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240527-sockmap-verify-deletes-v1-0-944b372f2101@cloudflare.com>

Hello:

This series was applied to bpf/bpf.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:

On Mon, 27 May 2024 13:20:06 +0200 you wrote:
> We have seen a few syzkaller reports of locking violations triggered by
> map_delete from sockmap/sockhash from an unexpected code path, for instance
> when irqs were disabled, or during a kfree inside a map_update.
> 
> The consensus is [1] to block map_delete op in the verifier for programs
> which are not allowed to update sockmap/sockhash already today, instead of
> trying to make sockmap deletes lock-safe in every possible context.
> 
> [...]

Here is the summary with links:
  - [bpf,1/3] bpf: Allow delete from sockmap/sockhash only if update is allowed
    https://git.kernel.org/bpf/bpf/c/98e948fb60d4
  - [bpf,2/3] Revert "bpf, sockmap: Prevent lock inversion deadlock in map delete elem"
    https://git.kernel.org/bpf/bpf/c/3b9ce0491a43
  - [bpf,3/3] selftests/bpf: Cover verifier checks for mutating sockmap/sockhash
    https://git.kernel.org/bpf/bpf/c/a63bf556160f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      parent reply	other threads:[~2024-05-27 17:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-27 11:20 [PATCH bpf 0/3] Block deletes from sockmap for tracing programs Jakub Sitnicki
2024-05-27 11:20 ` [PATCH bpf 1/3] bpf: Allow delete from sockmap/sockhash only if update is allowed Jakub Sitnicki
2024-05-27 16:49   ` John Fastabend
2024-05-27 11:20 ` [PATCH bpf 2/3] Revert "bpf, sockmap: Prevent lock inversion deadlock in map delete elem" Jakub Sitnicki
2024-05-27 16:50   ` John Fastabend
2024-05-27 11:20 ` [PATCH bpf 3/3] selftests/bpf: Cover verifier checks for mutating sockmap/sockhash Jakub Sitnicki
2024-05-27 16:52   ` John Fastabend
2024-05-27 16:46 ` [PATCH bpf 0/3] Block deletes from sockmap for tracing programs John Fastabend
2024-05-27 17:40 ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171683162928.10914.15797940779296702902.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=hdanton@sina.com \
    --cc=jakub@cloudflare.com \
    --cc=john.fastabend@gmail.com \
    --cc=kernel-team@cloudflare.com \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=syzbot+ec941d6e24f633a59172@syzkaller.appspotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox