From: patchwork-bot+netdevbpf@kernel.org
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf@vger.kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@kernel.org, memxor@gmail.com, eddyz87@gmail.com,
zacecob@protonmail.com, kernel-team@fb.com
Subject: Re: [PATCH bpf 1/2] bpf: Fix may_goto with negative offset.
Date: Fri, 21 Jun 2024 21:30:29 +0000 [thread overview]
Message-ID: <171900542993.18811.7456455981671416318.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240619235355.85031-1-alexei.starovoitov@gmail.com>
Hello:
This series was applied to bpf/bpf.git (master)
by Andrii Nakryiko <andrii@kernel.org>:
On Wed, 19 Jun 2024 16:53:54 -0700 you wrote:
> From: Alexei Starovoitov <ast@kernel.org>
>
> Zac's syzbot crafted a bpf prog that exposed two bugs in may_goto.
> The 1st bug is the way may_goto is patched. When offset is negative
> it should be patched differently.
> The 2nd bug is in the verifier:
> when current state may_goto_depth is equal to visited state may_goto_depth
> it means there is an actual infinite loop. It's not correct to prune
> exploration of the program at this point.
> Note, that this check doesn't limit the program to only one may_goto insn,
> since 2nd and any further may_goto will increment may_goto_depth only
> in the queued state pushed for future exploration. The current state
> will have may_goto_depth == 0 regardless of number of may_goto insns
> and the verifier has to explore the program until bpf_exit.
>
> [...]
Here is the summary with links:
- [bpf,1/2] bpf: Fix may_goto with negative offset.
https://git.kernel.org/bpf/bpf/c/635c7a3cb3bf
- [bpf,2/2] selftests/bpf: Add tests for may_goto with negative offset.
https://git.kernel.org/bpf/bpf/c/d3a2cbf6e4e5
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-06-21 21:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 23:53 [PATCH bpf 1/2] bpf: Fix may_goto with negative offset Alexei Starovoitov
2024-06-19 23:53 ` [PATCH bpf 2/2] selftests/bpf: Add tests for " Alexei Starovoitov
2024-06-20 13:04 ` [PATCH bpf 1/2] bpf: Fix " Eduard Zingerman
2024-06-21 21:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171900542993.18811.7456455981671416318.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=memxor@gmail.com \
--cc=zacecob@protonmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox