From: patchwork-bot+netdevbpf@kernel.org
To: Yonghong Song <yonghong.song@linux.dev>
Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org,
daniel@iogearbox.net, kernel-team@fb.com, martin.lau@kernel.org,
syzbot+ad9ec60c8eaf69e6f99c@syzkaller.appspotmail.com,
eddyz87@gmail.com
Subject: Re: [PATCH bpf-next v3 1/2] bpf: Fail verification for sign-extension of packet data/data_end/data_meta
Date: Wed, 24 Jul 2024 02:40:30 +0000 [thread overview]
Message-ID: <172178883062.19741.15730473419481345218.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240723153439.2429035-1-yonghong.song@linux.dev>
Hello:
This series was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:
On Tue, 23 Jul 2024 08:34:39 -0700 you wrote:
> syzbot reported a kernel crash due to
> commit 1f1e864b6555 ("bpf: Handle sign-extenstin ctx member accesses").
> The reason is due to sign-extension of 32-bit load for
> packet data/data_end/data_meta uapi field.
>
> The original code looks like:
> r2 = *(s32 *)(r1 + 76) /* load __sk_buff->data */
> r3 = *(u32 *)(r1 + 80) /* load __sk_buff->data_end */
> r0 = r2
> r0 += 8
> if r3 > r0 goto +1
> ...
> Note that __sk_buff->data load has 32-bit sign extension.
>
> [...]
Here is the summary with links:
- [bpf-next,v3,1/2] bpf: Fail verification for sign-extension of packet data/data_end/data_meta
https://git.kernel.org/bpf/bpf-next/c/8924c0a1d51b
- [bpf-next,v3,2/2] selftests/bpf: Add tests for ldsx of pkt data/data_end/data_meta accesses
https://git.kernel.org/bpf/bpf-next/c/eb1b55c4875a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-07-24 2:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 15:34 [PATCH bpf-next v3 1/2] bpf: Fail verification for sign-extension of packet data/data_end/data_meta Yonghong Song
2024-07-23 15:34 ` [PATCH bpf-next v3 2/2] selftests/bpf: Add tests for ldsx of pkt data/data_end/data_meta accesses Yonghong Song
2024-07-23 16:01 ` bot+bpf-ci
2024-07-24 2:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=172178883062.19741.15730473419481345218.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=eddyz87@gmail.com \
--cc=kernel-team@fb.com \
--cc=martin.lau@kernel.org \
--cc=syzbot+ad9ec60c8eaf69e6f99c@syzkaller.appspotmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox